-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pwa.manifest.metaVariables overrides my preferred settings in index.template.html #6718
Comments
Arguably a feature request rather than a bug. |
Extract from docs when pwa: {
// workboxPluginMode: 'InjectManifest',
// workboxOptions: {},
manifest: {
// ...
},
// Use this OR metaVariablesFn, but not both;
// variables used to inject specific PWA
// meta tags (below are default values);
metaVariables: {
appleMobileWebAppCapable: 'yes',
appleMobileWebAppStatusBarStyle: 'default',
appleTouchIcon120: 'statics/icons/apple-icon-120x120.png',
appleTouchIcon180: 'statics/icons/apple-icon-180x180.png',
appleTouchIcon152: 'statics/icons/apple-icon-152x152.png',
appleTouchIcon167: 'statics/icons/apple-icon-167x167.png',
appleSafariPinnedTab: 'statics/icons/safari-pinned-tab.svg',
msapplicationTileImage: 'statics/icons/ms-icon-144x144.png',
msapplicationTileColor: '#000000'
},
// (@quasar/app v1.6.2+)
// Optional, overrides metaVariables above;
// Use this OR metaVariables, but not both;
metaVariablesFn (manifest) {
// ...
return [
{
// this entry will generate:
// <meta name="theme-color" content="ff0">
tagName: 'meta',
attributes: {
name: 'theme-color',
content: '#ff0'
}
},
{
// this entry will generate:
// <link rel="apple-touch-icon" sizes="180x180" href="statics/icon-180.png">
tagName: 'link',
attributes: {
rel: 'apple-touch-icon',
sizes: '180x180',
href: 'statics/icon-180.png'
},
closeTag: false // this is optional;
// specifies if tag also needs an explicit closing tag;
// it's Boolean false by default
}
]
}
} Starting with |
Thank you! I'm a bit tight on cash like the rest of the world but I could walk away from this issue with out starting sponsorship. Hoping I can increase the amount one day. |
Describe the bug
I'm needing to use an alternative to Icon Genie that emits different icon file names and settings that I'm wanting to configure in
index.template.html
. However Quasar's PWA plugin is overriding my settings with code emitted into the finalindex.html
.Expected that setting
pwa.manifest.metaVariables
to null or{}
would remove the emitted code.However it's just merged with values that restore the defaults.
To Reproduce
Steps to reproduce the behavior:
$ quasar create myapp; cd myapp
$ quasar mode add pwa
$ quasar build -m pwa
$ tr '>' '\012' < dist/pwa/index.html # to view emitted code with line breaks
Observe that the following lines are emitted in
index.html
that I'd wish to suppress by settingpwa.manifest.metaVariables
to null or{}
.Observe that
manifest.json
also containsmetaVariables
that AFAIK does not belong in a manifest file (probably does no harm).Expected behavior
I need a way to remove all of the emitted lines in
index.html
shown above so I can manually configure them inindex.template.html
. FYI ... I'll also be using a different manifest file emitted by the other icon generator.Additional context
link
andmeta
tags are emitted by fillPwaTags()Alternative icon generator details.
The text was updated successfully, but these errors were encountered: