New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement local devirtualization #179

Open

quasilyte opened this issue Feb 8, 2022 · 0 comments

Owner

quasilyte commented Feb 8, 2022

Go compiler rarely does a good job at removing the interfaces overhead.
Here is an example:

func f(buf *bytes.Buffer) {
  var rw io.ReadWriter = b
  g(rw) // performs convI2I
}

//go:noinline
func g(r io.Reader) {}

Fixed code:

func f(buf *bytes.Buffer) {
  var rw = b // just use *bytes.Buffer directly
  g(rw) // cheaper conversion
}

//go:noinline
func g(r io.Reader) {}

Investigation needed: how often can we improve things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment