Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpe: add match expression support #653

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Jul 12, 2022

This adds support for CPE Match Expressions, as specified in NISTIR 7696.

Signed-off-by: Hank Donnay [email protected]

@hdonnay hdonnay marked this pull request as ready for review April 25, 2024 19:02
@hdonnay hdonnay requested a review from a team as a code owner April 25, 2024 19:02
@hdonnay hdonnay requested review from crozzy and removed request for a team April 25, 2024 19:02
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 47.78761% with 59 lines in your changes are missing coverage. Please review.

Project coverage is 55.82%. Comparing base (a24db2a) to head (b31d60d).
Report is 2 commits behind head on main.

Files Patch % Lines
toolkit/types/cpe/match.go 47.78% 56 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
+ Coverage   55.80%   55.82%   +0.01%     
==========================================
  Files         265      266       +1     
  Lines       16596    16709     +113     
==========================================
+ Hits         9261     9327      +66     
- Misses       6375     6420      +45     
- Partials      960      962       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crozzy
Copy link
Contributor

crozzy commented Apr 25, 2024

LGTM

This adds support for CPE Match Expressions, as specified in [NISTIR 7696].

[NISTIR 7696]: https://csrc.nist.gov/publications/detail/nistir/7696/final

Signed-off-by: Hank Donnay <[email protected]>
@crozzy
Copy link
Contributor

crozzy commented Apr 26, 2024

I think this is fine to merge re:release, unless you have some other reservations

@hdonnay
Copy link
Member Author

hdonnay commented Apr 26, 2024

/fast-forward

@github-actions github-actions bot merged commit b31d60d into quay:main Apr 26, 2024
8 checks passed
@hdonnay hdonnay deleted the hack/cpe-match branch April 26, 2024 16:00
@crozzy crozzy added the needs-changelog Label for PRs that need a changelog note. label May 10, 2024
@github-actions github-actions bot removed the needs-changelog Label for PRs that need a changelog note. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants