Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Instagram hack to get around access token requirement? #128

Open
raae opened this issue Oct 30, 2020 · 6 comments
Open

Add Instagram hack to get around access token requirement? #128

raae opened this issue Oct 30, 2020 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@raae
Copy link
Member

raae commented Oct 30, 2020

Should we create a hack for Instagram that skips using their oEmbed endpoint?

It would consist of getting the post's id using the schema from the provider list, and then just fill in the html that would have been returned by the oEmbed endpoint.

To activate one should add "hack": true or something to the Instagram options.

@raae raae changed the title Add Instagram hack? Add Instagram hack to get around access token requirement? Oct 30, 2020
@raae raae added enhancement New feature or request help wanted Extra attention is needed labels Oct 30, 2020
@nickytonline
Copy link
Collaborator

hack, sounds like a hack.😄

For the Instagram options, if there is no access token present, we can skip the oEmbed endpoint with perhaps a warning that no token was provided or some kind of message like that.

This way, it doesn't cause any friction for folks currently using the embed and if they provide a token, then that's good too.

Another idea could be an option called useAccessToken and the default value is set to true so to opt out, they need to explicitly set it to false.

@nickytonline
Copy link
Collaborator

Also, now I know why my embeds for IG aren't working. 😄

@raae
Copy link
Member Author

raae commented Nov 5, 2020

The solution I have so far in #132 is that it skips fetching if there is no access token, and prints an error to the console. But it does not stop the build.

The PL needs a look and if you like it then it can be merged and closed.

@raae
Copy link
Member Author

raae commented Nov 5, 2020

I agree a hack will just bloat the plugin, there is now a problem with Twitch oEmbeds as well.

@mayanksharma1133
Copy link

how to hack Instagram id
link

@raae
Copy link
Member Author

raae commented May 31, 2022

See settings per provider in the readme.

Not totally sure if this still works as my token has expired...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants