Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog article OGP tags #1080

Closed
k1ng440 opened this issue Sep 14, 2023 · 0 comments
Closed

Blog article OGP tags #1080

k1ng440 opened this issue Sep 14, 2023 · 0 comments
Assignees
@k1ng440

Comments

@k1ng440
Copy link
Contributor

k1ng440 commented Sep 14, 2023 •
edited
Loading

Currently, the og:type metadata on qljs blog posts is set to "website" but it should be "article" to provide more accurate information and improve visibility.

Steps to Reproduce:

  1. Go to blog article: Reacts rocks with quick-lint-js
  2. Inspect the page source code.
  3. Look for the <meta property="og:type" content="website"> tag.

Expected Behavior:

The og:type metadata should be set to "article" like this: <meta property="og:type" content="article">.
See ogp.me for more details
@strager strager assigned strager and k1ng440 and unassigned strager Sep 16, 2023
@k1ng440 k1ng440 mentioned this issue Sep 16, 2023
Closed
strager pushed a commit that referenced this issue Sep 22, 2023
@k1ng440 @strager
refactor(website): Website will use article in og:type tag in blo…
b2bc1a3 
…g articles.

See #1080 for the intention of this pull request.
@strager strager linked a pull request Sep 23, 2023 that will close this issue
refactor(website): Use article in og:type tag in blog articles. #1084
Closed
@strager strager closed this as completed Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k1ng440 k1ng440

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(website): Use article in og:type tag in blog articles. k1ng440/quick-lint-js
2 participants
@strager @k1ng440