-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fe): warn on confusing operator precedence of & and >> #1093
Conversation
CLA Assistant Lite bot Thank you for your contribution! Like many free software projects, you must sign our Contributor License Agreement before we can accept your contribution. EDIT: All contributors have signed quick-lint-js' Contributor License Agreement (CLA-v1.md). |
I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch looks good. Let me know if you want to make changes or if I should merge this as-is.
.bitshift_operator = right_op}); | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, clean logic. 👍
Co-authored-by: strager <[email protected]>
@toastin0 Is this ready to be merged? |
sorry, was working on a commit but then life got in the way :( |
lmk if there are any issues with the latest commit, and if not, should be good to merge! |
oh hey, just looked, and saw that there's already been an |
@toastin0 I will fix the conflicts (including renumbering diagnostic codes) if you don't. No worries. |
cool! then if there are no further issues with the commit, then we're good to merge :3 |
Landed as Git commit aaf8db6. I renamed E0715 to E0716, fixed an issue with the E0716.md examples, and ran clang-format on the code. |
closes #1056
i'm excited to hear any feedback you have, so please, let me know!