feat(website): update macOS build instructions #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Homebrew's LLVM formula installs libc++ in $(brew --previx)/llvm/lib/c++.
|
CLA Assistant Lite bot: Thank you for your contribution! Like many free software projects, you must sign our Contributor License Agreement before we can accept your contribution. You can agree to the Contributor License Agreement by copy-pasting the following message into a new comment on this GitHub pull request: I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md). You can retrigger this bot by commenting recheck in this Pull Request |
|
I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md). |
|
Why does Homebrew keep breaking things? 😔 |
|
Thanks for bringing this issue to my attention and for updating the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the macOS instructions for building from source.
I had a few linker errors when I first tried building from source, and after a bit of debugging I realized that Homebrew's LLVM formula installs
libc++in$(brew --previx)/llvm/lib/c++. UpdatingLDFLAGSfixed the build.