Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new diag for using ‘.’ after ‘?.’ #1133

Conversation

pepplejoshua
Copy link
Contributor

This closes #1128 -- it warns the user about using a dot After an optional chain. This cover optional chain with function call as well as optional chain with index expressions

This closes quick-lint#1128 -- it warns the user about using a dot After an optional chain. This cover optional chain with function call as well as optional chain with index expressions
Copy link

github-actions bot commented Dec 23, 2023

CLA Assistant Lite bot Thank you for your contribution! Like many free software projects, you must sign our Contributor License Agreement before we can accept your contribution.

EDIT: All contributors have signed quick-lint-js' Contributor License Agreement (CLA-v1.md).

@pepplejoshua
Copy link
Contributor Author

I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md).

Copy link
Collaborator

@strager strager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your patch looks great except for the documentation (see 'must fix' comment).

test/test-parse-warning.cpp Show resolved Hide resolved
docs/errors/E0717.md Outdated Show resolved Hide resolved
docs/errors/E0717.md Outdated Show resolved Hide resolved
docs/errors/E0717.md Outdated Show resolved Hide resolved
src/quick-lint-js/diag/diagnostic-types-2.h Outdated Show resolved Hide resolved
src/quick-lint-js/fe/parse-expression.cpp Outdated Show resolved Hide resolved
src/quick-lint-js/fe/parse-expression.cpp Outdated Show resolved Hide resolved
src/quick-lint-js/fe/parse.cpp Outdated Show resolved Hide resolved
src/quick-lint-js/fe/parse.cpp Outdated Show resolved Hide resolved
src/quick-lint-js/fe/parse.cpp Show resolved Hide resolved
@pepplejoshua pepplejoshua requested a review from strager January 3, 2024 04:06
@strager
Copy link
Collaborator

strager commented Jan 3, 2024

Landed as commit bdfccbd. Thanks for the patch!

@strager strager closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10$: warn on using . after ?.
2 participants