Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positives with Preact code #1152

Closed
strager opened this issue Jan 1, 2024 · 5 comments
Closed

false positives with Preact code #1152

strager opened this issue Jan 1, 2024 · 5 comments
Assignees
Labels
false positive Severe bug: quick-lint-js rejects valid code
Milestone

Comments

@strager
Copy link
Collaborator

strager commented Jan 1, 2024

Preact uses attribute names like class but quick-lint-js reports diagnostics for this.

Report: https://twitter.com/Hasen_Judi/status/1741916636687610004

@strager strager added the false positive Severe bug: quick-lint-js rejects valid code label Jan 1, 2024
@FlatMapIO
Copy link

FlatMapIO commented Jan 2, 2024

When I finished writing the issue I found this 🤣, I want it to be able to read tsconfig.json and /** @jsxImportSource framework */

@Kostas-Xafis
Copy link

+1 I was just about to open an issue too

@strager strager self-assigned this Jan 5, 2024
@jonathankowalski
Copy link

Same with Solid

@strager strager added this to the 3.1 milestone Jan 6, 2024
@strager
Copy link
Collaborator Author

strager commented Jan 10, 2024

Fixed the false positives in Git commit 6b3fdbe. Added a config option in Git commit 9dd4710: https://quick-lint-js.com/errors/jsx/.

These fixes will end up in the upcoming 3.1 release.

@strager strager closed this as completed Jan 10, 2024
@strager
Copy link
Collaborator Author

strager commented Jan 15, 2024

Version 3.1.0 has shipped with the fix. (It actually shipped 4 days ago, but I forgot to mention it here...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
false positive Severe bug: quick-lint-js rejects valid code
Projects
None yet
Development

No branches or pull requests

4 participants