Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12$: Improve diagnostic: f = () {} #461

Open
strager opened this issue Oct 7, 2021 · 3 comments · Fixed by #476
Open

12$: Improve diagnostic: f = () {} #461

strager opened this issue Oct 7, 2021 · 3 comments · Fixed by #476
Labels
for hire Get paid for working on this task: https://quick-lint-js.com/hiring.html good first issue Good for newcomers and C++ beginners

Comments

@strager
Copy link
Collaborator

strager commented Oct 7, 2021 

    client.on('open', () {
      ws.send('something');
    });

Expected: "missing '=>'"
@strager
Copy link
Collaborator Author

strager commented Oct 13, 2021

Similar:

    client.on('error', error {
      reportError(error);
    });

Expected: "missing '=>' or ','"

@strager strager changed the title Improve diagnostic: f = () {} 12$: Improve diagnostic: f = () {} Oct 13, 2021
@strager strager added for hire Get paid for working on this task: https://quick-lint-js.com/hiring.html good first issue Good for newcomers and C++ beginners labels Oct 13, 2021
@AmanGupta03 AmanGupta03 removed their assignment Oct 16, 2021
@singalhimanshu singalhimanshu mentioned this issue Oct 29, 2021
Merged
@strager strager self-assigned this Nov 2, 2021
strager pushed a commit that referenced this issue Nov 3, 2021
@singalhimanshu
Improve error for missing arrow operator
1393e47 
The following code:

    let f = () {}

Should report error_missing_arrow_operator_in_arrow_function
Fix: #461
@strager strager reopened this Nov 3, 2021
@strager strager removed their assignment Jan 8, 2022
@strager
Copy link
Collaborator Author

strager commented Oct 1, 2022

The looks_like_arrow_function_body variable in parse-expression.cpp looks like a good place to start poking around.

@HicaroD
Copy link
Contributor

HicaroD commented Sep 21, 2023

I claim this for-hire task. I expect payment after I complete this task. I will email the quick-lint-js team if I am assigned this task.

@HicaroD HicaroD removed their assignment Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for hire Get paid for working on this task: https://quick-lint-js.com/hiring.html good first issue Good for newcomers and C++ beginners
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve error for missing arrow operator
3 participants
@strager @AmanGupta03 @HicaroD