8$: Warn on for(;;){}while(cond);

[strager]

In the following examples, the programmer intended to write a do-while loop:

for(;;) {
} while (cond);

while (cond) {
} while (cond);

If we see while after a for or while loop's body, without any newline after the }, report a diagnostic.

[cphamWSU]

Hello, I'd like to take on this task as part of classwork to contribute to an open source project.

This is my first time doing so, and I'd love to reach out for some guidance. What would be the best medium to ask for help?

[strager]

Hello, I'd like to take on this task as part of classwork to contribute to an open source project.

Awesome! I'm happy to help you with this.

What would be the best medium to ask for help?

Here are some options:

• This GitHub issue
• My Twitch stream: https://twitch.tv/strager
• The quick-lint-js IRC channel: #quick-lint-js on LiberaChat
• My email: [email protected]

[cphamWSU]

Thanks for the quick response. I've been familiarizing myself with the relevant code and implementing the initial steps for a diagnostic. Now that I'm onto writing the production code, I wanted to check if I was on the right track.

Using parse_and_visit_do_while from parse-statement.cpp as a reference for how to evaluate source code tokens, my assumption is that the solution for this issue would be to add some logic that checks for tokens following the right curly brace inside of parse_and_visit_for and parse_and_visit_while in the same file. I would imagine that has_leading_newline will also end up playing a role.

Does any of that sound right?

[strager]

@cphamWSU Adding checks at the end of parse_and_visit_for sounds about right. Checking has_leading_newline for the while token sounds like a good idea too.