Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updated supported releases): Updated support for ParrotOS 6.1 #1279

Merged
merged 3 commits into from
Jun 24, 2024
Merged

chore(updated supported releases): Updated support for ParrotOS 6.1 #1279

merged 3 commits into from
Jun 24, 2024

Conversation

EuroNutellaMan
Copy link
Contributor

@EuroNutellaMan EuroNutellaMan commented Jun 15, 2024

Added support for:

  • ParrotOS 6.1

Removed support for:

  • ParrotOS 5.9

@EuroNutellaMan EuroNutellaMan changed the title chore(updated supported releases) Updated ParrotOS and NixOS chore(updated supported releases): Updated ParrotOS and NixOS Jun 15, 2024
@EuroNutellaMan EuroNutellaMan changed the title chore(updated supported releases): Updated ParrotOS and NixOS chore(updated supported releases): Updated support for ParrotOS 6.1 and NixOS 24.05 Jun 15, 2024
…nd NixOS 24.05

Added support for:

- ParrotOS 6.1
- NixOS 24.05

Removed support for:

- ParrotOS 5.9
- NixOS 23.05
Copy link
Member

@lj3954 lj3954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested changes to allow quickget to dynamically find the latest 2 releases of Parrot OS.

In addition, please remove NixOS from the PR, #1266 includes changes for that operating system.

quickget Outdated Show resolved Hide resolved
@EuroNutellaMan
Copy link
Contributor Author

I should have removed the NixOS changes

@EuroNutellaMan EuroNutellaMan changed the title chore(updated supported releases): Updated support for ParrotOS 6.1 and NixOS 24.05 chore(updated supported releases): Updated support for ParrotOS 6.1 Jun 17, 2024
@EuroNutellaMan
Copy link
Contributor Author

I can't figure out why the lint shellcheck keeps failing (not too familiar with github yet), do you want me to close this PR and redo it with the suggested changes?

I assumed it was due to the 2nd commit in which I accepted your suggestion, which isn't properly formatted but for whatever reason it doesn't let me rename that commit.

@lj3954
Copy link
Member

lj3954 commented Jun 19, 2024

I can't figure out why the lint shellcheck keeps failing (not too familiar with github yet), do you want me to close this PR and redo it with the suggested changes?

I assumed it was due to the 2nd commit in which I accepted your suggestion, which isn't properly formatted but for whatever reason it doesn't let me rename that commit.

It's because some of ShellCheck's lints don't align with the formatting used by quickemu. Please add this line above.

#shellcheck disable=SC2046,SC2005

@EuroNutellaMan
Copy link
Contributor Author

I can't figure out why the lint shellcheck keeps failing (not too familiar with github yet), do you want me to close this PR and redo it with the suggested changes?

I assumed it was due to the 2nd commit in which I accepted your suggestion, which isn't properly formatted but for whatever reason it doesn't let me rename that commit.

It's because some of ShellCheck's lints don't align with the formatting used by quickemu. Please add this line above.

#shellcheck disable=SC2046,SC2005

Where should I add it exactly?

@flexiondotorg flexiondotorg merged commit 7e919da into quickemu-project:master Jun 24, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants