Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fedora): Check whether the link value contains an actual .iso file #1503

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

azmodude
Copy link
Contributor

@azmodude azmodude commented Nov 4, 2024

Fixes #1502

Description

Make sure to download the .iso for Fedora Atomic Editions instead of the .ociarchive by checking the .link field for a regex match.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions

quickget Outdated Show resolved Hide resolved
Also remove the SHA256 requirement. Fedora provides these for all links
now.
Fixes quickemu-project#1502
@azmodude azmodude requested a review from lj3954 November 8, 2024 06:05
Copy link
Member

@lj3954 lj3954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test results confirm this fixes the issue for all Fedora releases. Nice work.

@lj3954 lj3954 merged commit ec0f276 into quickemu-project:master Nov 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: quickget downloads .ociarchive files instead of .iso files for Fedora Atomic Editions
2 participants