Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QuickJS-NG to jsvu #113

Closed
bnoordhuis opened this issue Nov 22, 2023 · 7 comments
Closed

Add QuickJS-NG to jsvu #113

bnoordhuis opened this issue Nov 22, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@bnoordhuis
Copy link
Contributor

Action items from GoogleChromeLabs/jsvu#141:

  1. provide binaries at a stable location for:
  • i686 and x86_64 windows
  • i686 and x86_64 linux
  • arm64 macos
  1. provide at a stable location a LATEST.json with {"version":"x.y.z"}

  2. PR jsvu

stable location = GH releases

@bnoordhuis bnoordhuis added the enhancement New feature or request label Nov 22, 2023
@saghul
Copy link
Contributor

saghul commented Nov 22, 2023

Fat macOS binaries?

@saghul
Copy link
Contributor

saghul commented Nov 22, 2023

I can start working on this.

@bnoordhuis
Copy link
Contributor Author

Fat macOS binaries?

For both x86_64 and arm64, you mean? If at all possible: yes, please.

I can start working on this.

Also: yes, please :-)

@saghul
Copy link
Contributor

saghul commented Nov 22, 2023

On it! I hope to make progress tonight.

@saghul
Copy link
Contributor

saghul commented Nov 22, 2023

I created #121 which builds the following binaries:

  • Linux: statically linked (musl) x86 and x86_64
  • Windows (MinGW): statically linked x86 and x86_64
  • macOS: fat executable with x86_64 and arm64

The next step will be to create a release when a tag is pushed and then create a GH release and upload said artifacts.

Once that is inplace, do we want to make our first release? Exciting times!

@saghul
Copy link
Contributor

saghul commented Nov 23, 2023

PR: GoogleChromeLabs/jsvu#142

@saghul
Copy link
Contributor

saghul commented Nov 24, 2023

PR landed!

@saghul saghul closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants