Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump constants should be in quickjs.h #769

Closed
mrmbernardi opened this issue Dec 25, 2024 · 2 comments
Closed

Dump constants should be in quickjs.h #769

mrmbernardi opened this issue Dec 25, 2024 · 2 comments

Comments

@mrmbernardi
Copy link
Contributor

https://github.com/quickjs-ng/quickjs/blob/482291286b9960c255ff8765d18a618cc87d89a2/quickjs.c#L81-L99

Although the comment implies its a qjs feature, the dumping is supported when quickjs is embedded anywhere. Therefore I think these should be in quickjs.h so embedders don't need to hardcode the numbers elsewhere. They should also be prefixed (perhaps with JS_ in order to avoid naming collisions.

@saghul
Copy link
Contributor

saghul commented Dec 25, 2024

Yeah makes sense. Would you like to send a PR?

@mrmbernardi
Copy link
Contributor Author

I'll get on it soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants