Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov kills our green check mark even when adding coverage #1007

Closed
3 tasks
faddat opened this issue Jan 5, 2024 · 1 comment
Closed
3 tasks

Codecov kills our green check mark even when adding coverage #1007

faddat opened this issue Jan 5, 2024 · 1 comment

Comments

@faddat
Copy link
Contributor

faddat commented Jan 5, 2024 •
edited
Loading

Summary of Bug

Codecov messes up our ability to use CI as a source of truth

There are better solutions so let's use one

Expected Behaviour

Adding test coverage should not result in angry codecov

Version

Master

Steps to Reproduce

Write code add tests and watch codecov cry

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@faddat faddat closed this as completed Jan 21, 2024
@faddat
Copy link
Contributor Author

faddat commented Jan 21, 2024

I am not even sure what I was referencing here.

proves this issue quite wrong. Should have included an example to say the least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@faddat