Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of the unwrap crate from quinn tests #1215

Closed
Ralith opened this issue Oct 29, 2021 · 3 comments
Closed

Remove use of the unwrap crate from quinn tests #1215

Ralith opened this issue Oct 29, 2021 · 3 comments
Assignees
@Rouzip
Labels
good first issue Good for newcomers

Comments

@Ralith
Copy link
Collaborator

Ralith commented Oct 29, 2021

This crate was a workaround for unwrap panic messages having a crappy source location, but this was fixed upstream in rust-lang/rust#47809. It's now a superfluous dependency, which could be easily dropped.
@Ralith Ralith added the good first issue Good for newcomers label Oct 29, 2021
@Rouzip
Copy link
Contributor

Rouzip commented Oct 30, 2021

This crate was a workaround for unwrap panic messages having a crappy source location, but this was fixed upstream in rust-lang/rust#47809. It's now a superfluous dependency, which could be easily dropped.

Hello, I think I can try to fix it.

@djc
Copy link
Member

djc commented Oct 30, 2021

@Rouzip would be great, thanks!

@Ralith
Copy link
Collaborator Author

Ralith commented Nov 1, 2021

Fixed in #1221.

@Ralith Ralith closed this as completed Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rouzip Rouzip

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ralith @djc @Rouzip