Skip to content

repository naming & documentation #3

Open
@MarcWeber

Description

@MarcWeber

http://drake.rubyforge.org/ says "A branch of Rake supporting automatic parallelizing of tasks"

Your github repository is called "rake", not drake. rake also has -j.
So your documentation should be updated telling which is the difference.

class MultiFile < Rake::FileTask
  private
  # rake
  # def invoke_prerequisites(task_args, invocation_chain) # :nodoc:
  #   invoke_prerequisites_concurrently(task_args, invocation_chain)
  # end

  # drake:
  def invoke_prerequisites(args, invocation_chain)
    threads = @prerequisites.collect { |p|
      Thread.new(p) { |r| application[r, @scope].invoke_with_call_chain(args, invocation_chain) }
    }
    threads.each { |t| t.join }
  end

end

def multifile(*args, &block)
    # file(*args, &block)
    MultiFile.define_task(*args, &block)
end

Is this the recommended way to get a multifile for drake?
I think a file "foo" do .. end.multi like syntax would be nicer, see jimweirich#205

On the mailinglist there has been some discussion about "different" engines, why not allow the user to choose one in the rakefile?

rake_config.engine = "rake / drake"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions