Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository naming & documentation #3

Open
MarcWeber opened this issue Jun 21, 2013 · 0 comments
Open

repository naming & documentation #3

MarcWeber opened this issue Jun 21, 2013 · 0 comments

Comments

@MarcWeber
Copy link

http://drake.rubyforge.org/ says "A branch of Rake supporting automatic parallelizing of tasks"

Your github repository is called "rake", not drake. rake also has -j.
So your documentation should be updated telling which is the difference.

class MultiFile < Rake::FileTask
  private
  # rake
  # def invoke_prerequisites(task_args, invocation_chain) # :nodoc:
  #   invoke_prerequisites_concurrently(task_args, invocation_chain)
  # end

  # drake:
  def invoke_prerequisites(args, invocation_chain)
    threads = @prerequisites.collect { |p|
      Thread.new(p) { |r| application[r, @scope].invoke_with_call_chain(args, invocation_chain) }
    }
    threads.each { |t| t.join }
  end

end

def multifile(*args, &block)
    # file(*args, &block)
    MultiFile.define_task(*args, &block)
end

Is this the recommended way to get a multifile for drake?
I think a file "foo" do .. end.multi like syntax would be nicer, see jimweirich#205

On the mailinglist there has been some discussion about "different" engines, why not allow the user to choose one in the rakefile?

rake_config.engine = "rake / drake"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant