Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unit systems: CGS, CONSTANTS, CUSTOM #782

Merged
merged 36 commits into from
Nov 4, 2024
Merged

Add support for unit systems: CGS, CONSTANTS, CUSTOM #782

merged 36 commits into from
Nov 4, 2024

Commits on Oct 26, 2024

  1. reduce nx in shock tests

    @chongchonghe
    chongchonghe committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    fce46d7 View commit details
    Browse the repository at this point in the history

  2. define cgs and k_B: passing shuosher and shock_cgs tests

    @chongchonghe
    chongchonghe committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    b7276fc View commit details
    Browse the repository at this point in the history

  3. cgs and k_B: shock test

    @chongchonghe
    chongchonghe committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    6fedb55 View commit details
    Browse the repository at this point in the history

  4. finish CGS and CONSTANTS definition, passing shock and shockcgs

    @chongchonghe
    chongchonghe committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    9a9dbea View commit details
    Browse the repository at this point in the history

  5. add G into CGS and CONSTANTS; passing star_cluster test

    @chongchonghe
    chongchonghe committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    acf7f06 View commit details
    Browse the repository at this point in the history

  6. compute constants from unit_length ... when using UnitSystem::CUSTUM

    @chongchonghe
    chongchonghe committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    432ef8a View commit details
    Browse the repository at this point in the history

  7. fix: use C::Gconst

    @chongchonghe
    chongchonghe committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    2688902 View commit details
    Browse the repository at this point in the history

  8. mod shock_cgs and line_cooling problems to test units conversion

    @chongchonghe
    chongchonghe committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    92a7e5f View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. add unit_length to Physics_Traits

    @chongchonghe
    chongchonghe committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    e28f243 View commit details
    Browse the repository at this point in the history

  2. finishing initializeSimulationMetadata and writing units to metadata

    @chongchonghe
    chongchonghe committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    6f7509c View commit details
    Browse the repository at this point in the history

  3. write both unit_xxx and constants into metadata for all unit systems

    @chongchonghe
    chongchonghe committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    5bd9e13 View commit details
    Browse the repository at this point in the history

  4. update in files

    @chongchonghe
    chongchonghe committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    621fe4e View commit details
    Browse the repository at this point in the history

  5. add comments

    @chongchonghe
    chongchonghe committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    babfcef View commit details
    Browse the repository at this point in the history

  6. set unit_xxx to NAN when units_system == CONSTANTS

    @chongchonghe
    chongchonghe committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    7316bb8 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    25d6c44 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. set unit_mass to NAN if CONSTNATS

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2010aa7 View commit details
    Browse the repository at this point in the history

  2. move c_light and c_hat to PhysicsTraits

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1c2e298 View commit details
    Browse the repository at this point in the history

  3. change c_hat to c_hat_over_c

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    55e4dd6 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2add579 View commit details
    Browse the repository at this point in the history

  5. remove print messages in MarshakAsymptotic

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ea0c0ee View commit details
    Browse the repository at this point in the history

  6. minor fixes

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    ff75400 View commit details
    Browse the repository at this point in the history

  7. update all tests to adapt new unit systems

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6f84a04 View commit details
    Browse the repository at this point in the history

  8. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b21d2d9 View commit details
    Browse the repository at this point in the history

  9. remove some static_assert

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    9446336 View commit details
    Browse the repository at this point in the history

  10. fix advection2d

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    57efbf2 View commit details
    Browse the repository at this point in the history

  11. fix boltzmann_constant errors

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    0ad4f46 View commit details
    Browse the repository at this point in the history

  12. fix chat error

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    7b4b8bc View commit details
    Browse the repository at this point in the history

  13. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    36f0f27 View commit details
    Browse the repository at this point in the history

  14. fix bugs

    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    8d3a70c View commit details
    Browse the repository at this point in the history

  15. Merge branch 'chong/add-units-conversion' of https://github.com/quokk… 

    …a-astro/quokka into chong/add-units-conversion
    @chongchonghe
    chongchonghe committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    193674d View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. add static_assert unit_system == CGS in RandomBlast test

    @chongchonghe
    chongchonghe committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    27ae3cd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into chong/add-units-conversion

    @chongchonghe
    chongchonghe committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    74ebd2d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. fix bug

    @chongchonghe
    chongchonghe committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    6f7a4bc View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. set G = 1 in SphericalCollapse

    @chongchonghe
    chongchonghe committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f929133 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. fix minor bug

    @chongchonghe
    chongchonghe committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    226a401 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. pltfile from line_cooling

    @chongchonghe
    chongchonghe committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    51cf496 View commit details
    Browse the repository at this point in the history