Write 2D plotfiles for projections #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWibking
changed the title
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
…om:quokka-astro/quokka into BenWibking/output-2d-plotfiles-projections
for more information, see https://pre-commit.ci
…om:quokka-astro/quokka into BenWibking/output-2d-plotfiles-projections
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
dosubot
bot
added
the
size:XL
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
BenWibking
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
markkrumholz
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Code changes look good to me; build failures appear to be unrelated, and have to do with a missing h5py. Let me know if you need me to ping IT about something in the python environment on avatargpu. I will approve for now, but we'll need to sort out the h5py issue and re-run the tests before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Writes projections as 2D plotfiles, rather than as 3D plotfiles with one cell in the 3rd dimension.
Related issues
Fixes #685.
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
xinside the square brackets[ ]in the Markdown source below:/azp run.