Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messy logic for notifications sending #771

Open
KitsuneRal opened this issue Apr 11, 2021 · 0 comments
Open

Messy logic for notifications sending #771

KitsuneRal opened this issue Apr 11, 2021 · 0 comments
Labels
enhancement A feature or change request for Quaternion

Comments

@KitsuneRal
Copy link
Member

The way it's done is handling a signal when the number of highlights changes and making a notification if the number is more than 0. First off, this misses on the case when the room with the notification is already on the screen - there's no point in making a notification in that case. Second, it can miss notifications when the number of highlights doesn't change due to one new highlight in and one old one out.

@KitsuneRal KitsuneRal added the enhancement A feature or change request for Quaternion label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for Quaternion
Projects
Status: 0.0.97 - To Do
Development

No branches or pull requests

1 participant