Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Scroll to read marker" doesn't do anything if that event is not loaded #799

Open
KitsuneRal opened this issue Sep 30, 2021 · 1 comment
Labels
bug/fix Quaternion doesn't work as expected

Comments

@KitsuneRal
Copy link
Member

To reproduce:

  1. Find a room with a read marker far enough in the history so that Quaternion doesn't load it at once.
  2. Click the "scroll to read marker" button.
  3. Nothing happens.

An expected result (that's how Element iOS works, e.g.) is to load history until the event with the read marker is encountered and then navigate to it. It can be somewhat slow due to network requests (potentially several) so visual feedback is also important. Note: loading history until the read marker sounds like a good addition to libQuotient.

@KitsuneRal KitsuneRal added the bug/fix Quaternion doesn't work as expected label Sep 30, 2021
@KitsuneRal
Copy link
Member Author

Some work has been done in 775245d; that makes for somewhat confusing UX where the same button forces loading chunks of history and then jumps to the read marker. A better way (barring discontinuous timeline) would still be to load as much history as needed providing some feedback on what's happening and then automatically navigate to the read marker.

KitsuneRal added a commit that referenced this issue Oct 3, 2021
This is yet another workaround for what should be fixed in #799.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/fix Quaternion doesn't work as expected
Projects
Status: 0.0.97 - To Do
Development

No branches or pull requests

1 participant