Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited replies are not displayed as replies #864

Open
KitsuneRal opened this issue Apr 18, 2023 · 1 comment
Open

Edited replies are not displayed as replies #864

KitsuneRal opened this issue Apr 18, 2023 · 1 comment
Labels
bug/fix Quaternion doesn't work as expected

Comments

@KitsuneRal
Copy link
Member

The below either requires using another client that is capable of replying and editing already, or checking out the code from #848. This is not a problem in #848; edited replies made in other clients are shown equally incorrectly.
To reproduce:

  1. Make a reply to another message (i.e. make a message event with m.relates_to::m.in_reply_to subobject in its content).
  2. Edit this reply and send it.
  3. Find the edited reply in Quaternion's timeline.

ER: the message is displayed as a reply and also annotated with "(edited)".

AR: the message is annotated as edited but is no more a reply.

@KitsuneRal KitsuneRal added the bug/fix Quaternion doesn't work as expected label Apr 18, 2023
@KitsuneRal
Copy link
Member Author

...and this happens because the edit intentionally removes reply fallbacks. It's time to stop relying on those, generally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/fix Quaternion doesn't work as expected
Projects
Status: 0.0.97 - To Do
Development

No branches or pull requests

1 participant