Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No tests are run for PRs? #68

Closed
mikegerber opened this issue Aug 16, 2022 · 3 comments
Closed

No tests are run for PRs? #68

mikegerber opened this issue Aug 16, 2022 · 3 comments
Assignees

Comments

@mikegerber
Copy link
Member

#67 caused the code to fail, and the tests weren't run for the PR. Why?

@kba
Copy link
Contributor

kba commented Aug 16, 2022

#67 caused the code to fail, and the tests weren't run for the PR. Why?

Pull requests from branches in other remotes are not tested in Circle CI by default for security reasons (they could extract secrets like passwords and tokens). You have to enable "Build forked pull requests" in the settings.

@mikegerber mikegerber self-assigned this Aug 18, 2022
@mikegerber
Copy link
Member Author

mikegerber commented Aug 18, 2022

Pull requests from branches in other remotes are not tested in Circle CI by default for security reasons (they could extract secrets like passwords and tokens). You have to enable "Build forked pull requests" in the settings.

Thanks! I'll need to think about this.

@mikegerber
Copy link
Member Author

Fixed in #96.

Needs more review for security: I checked the security guides and updated some settings but with this stuff it's best to look twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants