Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review changes of #83 #84

Open
5 tasks
mikegerber opened this issue May 26, 2023 · 0 comments
Open
5 tasks

Review changes of #83 #84

mikegerber opened this issue May 26, 2023 · 0 comments
Assignees

Comments

@mikegerber
Copy link
Member

mikegerber commented May 26, 2023

I decided to merge #83 as is because of my vacation, but I had some minor changes to consider.

(List also includes things that I stumbled upon while reviewing, that were not part of #83.)

  • Review averaging of scores
  • Distinguish configuration from results - e.g. differences should be named better, perhaps show_differences
  • Add some types here and there, would have helped with differences (boolean config param) vs diff_c (the differences)
  • Consistent imports (sometimes relative, sometimes not)
  • Differences are encoding with a magic string ("Augenblick :: Augemblick"), I'd prefer tuples if that makes sense
@mikegerber mikegerber self-assigned this May 26, 2023
@mikegerber mikegerber changed the title Reviev changes of #83 Review changes of #83 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant