Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests + CI #6

Open
2 tasks
mikegerber opened this issue Jul 25, 2023 · 4 comments
Open
2 tasks

Add tests + CI #6

mikegerber opened this issue Jul 25, 2023 · 4 comments
Assignees

Comments

@mikegerber
Copy link
Member

  • Tests
  • CI
@mikegerber mikegerber self-assigned this Jul 25, 2023
@mikegerber
Copy link
Member Author

Some basic CI functionality is there, but

  • only a dummy test for now
  • there seems to be no standard on specifying tests in pyproject (setuptools has test_suite but is it deprecated now as setup.py test seems to be deprecated?)
  • only runs on release (this is easily fixable)

@mikegerber mikegerber mentioned this issue Aug 2, 2023
8 tasks
@mikegerber
Copy link
Member Author

Testing this is a bit tricky:

  • Build a local wheel and serve it via HTTP (serve-local-wheel.sh)
  • Have a test project and install it using pip --extra-index-url
    • How to make sure it only uses the test-built wheel, not the old one on PyPI?
  • Check that the version came from ocrd-tool.json

@mikegerber
Copy link
Member Author

I found a simpler way to test this: Build a test project without build isolation, with setuptools_ocrd installed in the active virtualenv: python3 -m build --no-isolation.

Documented here https://github.com/qurator-spk/setuptools_ocrd/blob/master/README-DEV.md#without-build-isolation

@mikegerber
Copy link
Member Author

I've added a test project in test_project/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant