Add SIA405 strings to value lists [WIP/STUB] #334
Conversation
|
Added new commits :
|
|
Todo before merging
|
autre, inconnu, à déterminer - > unbekannt (commit de test)
Add water quality mapping
Add altimetric precision mapping
Add bedding materials mapping
Add pipe function mapping
Add install method mapping
Add valve function mapping
Add Valve actuation mapping
| UPDATE qwat_vl.hydrant_material SET sia405code = 'unbekannt' WHERE value_fr = 'à déterminer'; | ||
|
|
||
| -- TODO : complete mapping | ||
| -- UPDATE qwat_vl.hydrant_model_inf SET sia405code = 'unbekannt' WHERE ???; |
There was a problem hiding this comment.
I think all hydrant_model_inf are Hydrant.Art = Oberflurhydrant. We would need to fill in the subvalues in qwat for a detailled matching (einarmig, zweiarmig, dreiarmig, mitEntleerung, ohne. Also we should take the Information about the Hersteller out of these values (e.g. VonRoll)
There was a problem hiding this comment.
My question is, whether we invest in the matching here or add addtional columns to qwat_vl.hydrant_model_sup for Art and Hersteller. Online I can find some of e.g. the vonRoll models: https://www.vonroll-hydro.pl/en/hydrants.html e.g 5601 is einarmig
| -- UPDATE qwat_vl.hydrant_model_inf SET sia405code = 'unbekannt' WHERE ???; | ||
|
|
||
| -- TODO : complete mapping | ||
| -- UPDATE qwat_vl.hydrant_model_sup SET sia405code = 'unbekannt' WHERE ???; |
There was a problem hiding this comment.
I think all hydrant_model_sup are Hydrant.Art = Unterflurhydrant. We would need to fill in the subvalues in qwat for a detailled matching (einarmig, zweiarmig, mitEntleerung, ohne. Also we should take the Information about the Hersteller out of these values (e.g. VonRoll). My question is, whether we invest in the matching here or add addtional columns to qwat_vl.hydrant_model_sup for Art and Hersteller.
There was a problem hiding this comment.
Hydrant.Hersteller is already stored separately as hydrant_provider
| -- UPDATE qwat_vl.hydrant_model_sup SET sia405code = 'unbekannt' WHERE ???; | ||
|
|
||
| -- TODO : complete mapping | ||
| -- UPDATE qwat_vl.hydrant_output SET sia405code = 'unbekannt' WHERE ???; |
There was a problem hiding this comment.
Here I think I find (hidden) information whether it is einarmig, zweiarmig, dreiarmig: 2x55_1x75 or 3x75 - maybe we have to combine hydrant_model_* and hydrant_output for the Hydrant.Art matching in SIA405 water.
| -- UPDATE qwat_vl.hydrant_output SET sia405code = 'unbekannt' WHERE ???; | ||
|
|
||
| -- TODO : complete mapping | ||
| -- UPDATE qwat_vl.hydrant_provider SET sia405code = 'unbekannt' WHERE ???; |
There was a problem hiding this comment.
Hydrant.Hersteller is stored separately here as hydrant_provider
| -- UPDATE qwat_vl.pump_operating SET sia405code = 'unbekannt' WHERE ???; | ||
|
|
||
| -- TODO : complete mapping | ||
| -- UPDATE qwat_vl.pump_type SET sia405code = 'unbekannt' WHERE ???; |
There was a problem hiding this comment.
UPDATE qwat_vl.pump_type SET sia405code = 'andere' WHERE value_fr = 'autre';
UPDATE qwat_vl.pump_type SET sia405code = 'unbekannt' WHERE value_fr = 'inconnu';
UPDATE qwat_vl.pump_type SET sia405code = 'unbekannt' WHERE value_fr = 'à déterminer';
UPDATE qwat_vl.pump_type SET sia405code = 'Pumpwerk.Druckerhoehungsanlage' WHERE value_fr = 'surpresseur';
UPDATE qwat_vl.pump_type SET sia405code = 'Pumpwerk.Hauptpumpwerk' WHERE value_fr = 'normal';
-- not sure about this matching
UPDATE qwat_vl.pump_type SET sia405code = 'Pumpwerk.Zwischenpumpwerk' WHERE value_fr = 'accélération';
There was a problem hiding this comment.
@kandre peux-tu nous confirmer Zwischenpumpwerk <-> accélération?
| UPDATE qwat_vl.status SET sia405code = 'weitere.Projekt' WHERE value_fr = 'projet en execution'; | ||
|
|
||
| -- TODO : complete mapping | ||
| -- UPDATE qwat_vl.subscriber_type SET sia405code = 'unbekannt' WHERE ???; |
There was a problem hiding this comment.
I do not see an equivalent in SIA405 water for subscriber_type in the corresponding class Hausanschluss
There was a problem hiding this comment.
Add to attribute Hausanschluss.Art (Text attribute)
| -- UPDATE qwat_vl.survey_type SET sia405code = 'unbekannt' WHERE ???; | ||
|
|
||
| -- TODO : complete mapping | ||
| -- UPDATE qwat_vl.tank_firestorage SET sia405code = 'unbekannt' WHERE ???; |
There was a problem hiding this comment.
I do not see an equivalent in SIA405 water. There is a Loeschwasserreserve: MANDATORY 0.00 .. 10000000.00 [Units.m3]; in Wasserbehaelter as attribute
There was a problem hiding this comment.
@tproduit y a-t-il des informations complémentaires pour la base des planifications d'eaux de secours pour le modèle fédéral qui requerraient des ajouts dans QWAT? Volume, ...?
| UPDATE qwat_vl.valve_actuation SET sia405code = 'unbekannt' WHERE value_fr = 'inconnu'; | ||
| UPDATE qwat_vl.valve_actuation SET sia405code = 'unbekannt' WHERE value_fr = 'à déterminer'; | ||
| UPDATE qwat_vl.valve_actuation SET sia405code = 'mechanisch' WHERE value_fr = 'manuel'; | ||
| UPDATE qwat_vl.valve_actuation SET sia405code = 'mechanisch' WHERE value_fr = 'manuel à gauche'; |
There was a problem hiding this comment.
Here also set Absperrorgan.Schliessrichtung = links
There was a problem hiding this comment.
@olivierdalang même chose que ci-dessous.
| UPDATE qwat_vl.valve_actuation SET sia405code = 'unbekannt' WHERE value_fr = 'autre'; | ||
| UPDATE qwat_vl.valve_actuation SET sia405code = 'unbekannt' WHERE value_fr = 'inconnu'; | ||
| UPDATE qwat_vl.valve_actuation SET sia405code = 'unbekannt' WHERE value_fr = 'à déterminer'; | ||
| UPDATE qwat_vl.valve_actuation SET sia405code = 'mechanisch' WHERE value_fr = 'manuel'; |
There was a problem hiding this comment.
Here also set Absperrorgan.Schliessrichtung = rechts
There was a problem hiding this comment.
@olivierdalang comment faire dans le cas d'un attribut qui renseigne deux attributs dans SIA?
There was a problem hiding this comment.
Le plus simple serait d'avoir deux colonnes (p. ex. utiliser sia405code pour Schaltantrieb et ajouter une colonne sia405code_schliessrichtung).
| UPDATE qwat_vl.valve_function SET sia405code = 'Schieber.unbekannt' WHERE value_fr = 'jauge'; | ||
|
|
||
| -- TODO : complete mapping | ||
| -- UPDATE qwat_vl.valve_maintenance SET sia405code = 'unbekannt' WHERE ???; |
There was a problem hiding this comment.
Just copy value to Absperrorgan.Zustand (TEXT*30)
Add leak cause mapping
Overall Check with @sjib
|
@ponceta @sjib Hey ! Let me know when you're done with the first pass so that I can merge this. As we discussed, it doesn't need to be perfect, just the minimum for the export to contain useful information. We'll improve incrementally afterwards. With the current file, I get the following validation errors when exporting the demo data : I guess we want |
|
Yes-- Stefan BurckhardtAm 10.08.21, 11:07 schrieb Olivier Dalang ***@***.***>:
@ponceta @sjib Hey ! Let me know when you're done with the first pass so that I can merge this. As we discussed, it doesn't need to be perfect, just the minimum for the export to contain useful information. We'll improve incrementally afterwards.
With the current file, I get the following validation errors when exporting the demo data :
Error: line 1770: SIA405_WASSER_2015_LV95.SIA405_Wasser.Leitung: tid ch00000000006265: value Kunststoff is not a member of the enumeration in attribute Material
Error: line 6311: SIA405_WASSER_2015_LV95.SIA405_Wasser.Schadenstelle: tid ch00000000008730: value Bruch.Riss is not a member of the enumeration in attribute Art
I guess we want Riss intead of Bruch.Riss, and some subvalue of Kunststoff
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
|
|
Indeed, @olivierdalang feel free to adapt what is necessary to have the minimal export running. |
|
@olivierdalang is the file |
|
@lbartoletti Not sure I understand, what is wrong with |
|
@olivierdalang By convention - don't remember if it was required by pum or the CI - deltas have a 3 digits id to perform update. |
|
ah ok, in this case I don't think it's necessary as we're already released 1.3.6 (beta) so that the next would be 1.3.7. It would be useful in the case where we could have multiple deltas in the same version, to ensure they apply in correct order. |
This is needed to import from/to SIA405.
Actual matching is just a stub so far. @sjib Could your metadatabase scripts by any chance help in automating the matching ? Or do we need to do that by hand ?