Skip to content

Commit 2ef8a9a

Browse files
fix: comment out bundle issue when changing user pref (#935)
1 parent 6f1e462 commit 2ef8a9a

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

packages/themes/src/lib/provider.tsx

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {
99
useOnWindow,
1010
useSignal,
1111
useTask$,
12-
useVisibleTask$,
1312
} from '@builder.io/qwik';
1413
import { ThemeScript } from './theme-script';
1514
import type { SystemTheme, Theme, ThemeProviderProps, UseThemeProps } from './types';
@@ -71,26 +70,27 @@ export const ThemeProvider = component$<ThemeProviderProps>(
7170
}
7271
});
7372

73+
// DO NOT UNCOMMENT. THIS CAUSES BUNDLE ISSUE ACROSS SITE -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
7474
// eslint-disable-next-line qwik/no-use-visible-task -- not possible atm to useOnWindow for a MediaQueryList event
75-
useVisibleTask$(({ cleanup }) => {
76-
themeSig.value = localStorage.getItem(storageKey) || defaultTheme;
77-
const media = window.matchMedia('(prefers-color-scheme: dark)');
75+
// useVisibleTask$(({ cleanup }) => {
76+
// // themeSig.value = localStorage.getItem(storageKey) || defaultTheme;
77+
// const media = window.matchMedia('(prefers-color-scheme: dark)');
7878

79-
const handleMediaQuery = (e: MediaQueryListEvent | MediaQueryList) => {
80-
const resolved = getSystemTheme(e);
81-
resolvedThemeSig.value = resolved;
79+
// const handleMediaQuery = $((e: MediaQueryListEvent | MediaQueryList) => {
80+
// const resolved = getSystemTheme(e);
81+
// resolvedThemeSig.value = resolved;
8282

83-
if (themeSig.value === 'system' && enableSystem && !forcedTheme) {
84-
applyTheme('system');
85-
}
86-
};
83+
// if (themeSig.value === 'system' && enableSystem && !forcedTheme) {
84+
// applyTheme('system');
85+
// }
86+
// });
8787

88-
media.addEventListener('change', handleMediaQuery);
88+
// media.addEventListener('change', handleMediaQuery);
8989

90-
handleMediaQuery(media);
90+
// handleMediaQuery(media);
9191

92-
cleanup(() => media.removeEventListener('change', handleMediaQuery));
93-
});
92+
// cleanup(() => media.removeEventListener('change', handleMediaQuery));
93+
// });
9494

9595
// localStorage event handling
9696

0 commit comments

Comments
 (0)