Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated C++ functions #676

Closed
hadley opened this issue Dec 13, 2023 · 4 comments
Closed

Replace deprecated C++ functions #676

hadley opened this issue Dec 13, 2023 · 4 comments
Milestone
v1.5.0

Comments

@hadley
Copy link
Member

hadley commented Dec 13, 2023 •
edited
Loading 

     nanodbc/nanodbc.cpp:301:32: warning: 'codecvt_utf8_utf16<char16_t>' is deprecated [-Wdeprecated-declarations]
     nanodbc/nanodbc.cpp:301:16: warning: 'wstring_convert<std::codecvt_utf8_utf16<char16_t>, char16_t>' is deprecated [-Wdeprecated-declarations]

Due to https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0618r0.html
@hadley hadley mentioned this issue Dec 14, 2023
Closed
17 tasks
@hadley hadley added this to the v1.5.0 milestone Dec 14, 2023
@hadley
Copy link
Member Author

hadley commented Dec 14, 2023

I'll try and get through the current submission with this but we'll need to fix for the next release.

@detule
Copy link
Collaborator

detule commented Dec 16, 2023

For what is worth, nanodbc is waiting for the standard to provide an alternative:

nanodbc/nanodbc#74

@hadley
Copy link
Member Author

hadley commented Dec 16, 2023

In that case maybe we should pragma the warnings away.

@hadley
Copy link
Member Author

hadley commented Dec 18, 2023

Fixed in #688

@hadley hadley closed this as completed Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
2 participants
@hadley @detule