Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup job fails when clang-ubsan is included #656

Closed
ctoney opened this issue Feb 27, 2025 · 2 comments
Closed

setup job fails when clang-ubsan is included #656

ctoney opened this issue Feb 27, 2025 · 2 comments

Comments

@ctoney
Copy link

ctoney commented Feb 27, 2025

Such an awesome service! Thank you for the excellent work here.

I've been using clang-asan and valgrind regularly for some time now and they are tremendously helpful.

If I include the new clang-ubsan alone or in combination with other checks, the action always fails at setup, cf.
https://github.com/ctoney/gdalraster/actions/runs/13575477164
vs
https://github.com/ctoney/gdalraster/actions/runs/13575486550

Or in combination: https://github.com/ctoney/gdalraster/actions/runs/13575462731

I believe at some point in the recent past, -fsanitize=undefined was also used in the clang-asan check. Is the addition of clang-ubsan intended to provide those as separate checks now?

@gaborcsardi
Copy link
Collaborator

You need to use a newer release, you are hard-coding an older one:
https://github.com/ctoney/gdalraster/blob/d32f80b91739a353c0fd6aaf44be64dd12a4f25e/.github/workflows/rhub.yaml#L38

    steps:
    # NO NEED TO CHECKOUT HERE
    - uses: r-hub/actions/setup@1607aa150e4d33e2b4a2005c214c27dff7b792e9 # v1.5.0
      with:
        config: ${{ github.event.inputs.config }}
      id: rhub-setup

@ctoney
Copy link
Author

ctoney commented Feb 27, 2025

Right, thanks! I'll blame that on Dependabot which wants me to do it that way. It bumped to 1.5 back in January but hasn't updated since. I'll sort that out. Sorry for the noise.

@ctoney ctoney closed this as completed Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants