Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the acquireUtilsMacOS() error message be tweaked? #952

Closed
dylanhmorris opened this issue Nov 22, 2024 · 3 comments
Closed

Should the acquireUtilsMacOS() error message be tweaked? #952

dylanhmorris opened this issue Nov 22, 2024 · 3 comments

Comments

@dylanhmorris
Copy link

dylanhmorris commented Nov 22, 2024

It appears that any macos util installation failure (e.g. a failure to install pkgconfig or ghostscript) triggers an error message that references qpdf specifically. Is this intended or should the error message be made more general? Might help people when dealing with things like #948

async function acquireUtilsMacOS() {
// qpdf is needed by `--as-cran`
try {
process.env.HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK = "true";
await exec.exec("brew", [
"install",
"qpdf",
"pkgconfig",
"checkbashisms",
"ghostscript",
], { silent: true });
} catch (error) {
core.debug(`${error}`);
throw `Failed to install qpdf: ${error}`;
}
}

Happy to make a small PR if a change would be welcome.

@krlmlr
Copy link
Member

krlmlr commented Nov 24, 2024

Perhaps we can also have a mode where silent: false is set, perhaps during GHA debugging?

@gaborcsardi
Copy link
Member

Done in v2.11.1.

Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this issue

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants