Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable file hyperlinks #744

Merged
merged 14 commits into from
Jan 10, 2025
Merged

Configurable file hyperlinks #744

merged 14 commits into from
Jan 10, 2025

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Dec 17, 2024

This PR makes it possible for Positron (or any execution context) to inform cli how file hyperlinks need to be constructed in order to work in Positron's terminals. What I mean by "work" is that file hyperlinks open in this product and don't delegate to the operating system. This is beneficial for Positron's R package development tasks, most especially devtools::test(), which will emit links like path/to/test-foo:10:3 when tests fail. Companion to the already-merged #739. Here's a video of running devtools::test() and taking advantage of clickable filepaths and runnable code (for reviewing or accepting snapshots):

Screen.Recording.2024-12-16.at.4.10.39.PM.mov

Note the screen recording is made with a local branch of Positron, which also needs another PR to take advantage of the cli changes.

@@ -1,6 +1,6 @@
Package: cli
Title: Helpers for Developing Command Line Interfaces
Version: 3.6.3.9001
Version: 3.6.3.9002
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to need to detect this version in Positron. We only want to enable hyperlinks in the relevant terminals if we know they're going work exactly as we want.

paste0(abs_path(params$path), params$suffix),
params = params$params
link$url,
params = link$params
)
})
ret
}

parse_file_link_params <- function(txt) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This became narrower, i.e. just about parsing.

} else {
list(path = path, params = c(line = num, col = "1"))
}
construct_file_link <- function(params) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This turns the parsed filepath into the data style_hyperlink() needs.

list(path = path, params = c(line = num, col = "1"))
}
construct_file_link <- function(params) {
fmt <- get_config_chr("hyperlink_file_url_format")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it stands, only an explicitly configured hyperlink format has any effect.

But you could imagine detecting that we're in, e.g. a Positron or VS Code terminal, and setting this configuration from the cli side. Food for thought. But definitely something that could be added later.

@jennybc
Copy link
Member Author

jennybc commented Dec 17, 2024

I took inspiration from other tools, such as ripgrep. Here's how ripgrep can be configured to construct hyperlinks for various environments:

https://github.com/BurntSushi/ripgrep/blob/bf63fe8f258afc09bae6caa48f0ae35eaf115005/crates/printer/src/hyperlink_aliases.rs#L4-L22

/// Aliases to well-known hyperlink schemes.
///
/// These need to be sorted by name.
const HYPERLINK_PATTERN_ALIASES: &[(&str, &str)] = &[
    #[cfg(not(windows))]
    ("default", "file://{host}{path}"),
    #[cfg(windows)]
    ("default", "file://{path}"),
    ("file", "file://{host}{path}"),
    // https://github.com/misaki-web/grepp
    ("grep+", "grep+://{path}:{line}"),
    ("kitty", "file://{host}{path}#{line}"),
    // https://macvim.org/docs/gui_mac.txt.html#mvim%3A%2F%2F
    ("macvim", "mvim://open?url=file://{path}&line={line}&column={column}"),
    ("none", ""),
    // https://macromates.com/blog/2007/the-textmate-url-scheme/
    ("textmate", "txmt://open?url=file://{path}&line={line}&column={column}"),
    // https://code.visualstudio.com/docs/editor/command-line#_opening-vs-code-with-urls
    ("vscode", "vscode://file{path}:{line}:{column}"),
    ("vscode-insiders", "vscode-insiders://file{path}:{line}:{column}"),
    ("vscodium", "vscodium://file{path}:{line}:{column}"),
];

Documentation of the vscode:// URL scheme and, therefore, the positron:// URL scheme:

https://code.visualstudio.com/docs/editor/command-line#_opening-vs-code-with-urls

delta is another tool that has a similar configuration point:

https://dandavison.github.io/delta/tips-and-tricks/using-delta-with-vscode.html

https://dandavison.github.io/delta/hyperlinks.html

@jennybc
Copy link
Member Author

jennybc commented Dec 19, 2024

In actual use this is looking pretty good now. For my own convenience, I want to record how to test drive this even without the necessary changes in Positron.

In a terminal inside VS Code, set up some environment variables and then start R:

export R_CLI_HYPERLINKS=true
export R_CLI_HYPERLINK_FILE_URL_FORMAT=vscode://file{path}:{line}:{column}
R

In that R session, you should be able to create cli file hyperlinks and Ctrl/Cmd+click on them to open in VS Code, e.g.:

cli::cli_text("{.file ~/.gitconfig}")

Likewise, you could achieve the same in a terminal inside a released version of Positron by changing the file hyperlink format:

export R_CLI_HYPERLINKS=true
export R_CLI_HYPERLINK_FILE_URL_FORMAT=positron://file{path}:{line}:{column}
R

I'll be back to soon finalize this and remove the draft status.

@jennybc
Copy link
Member Author

jennybc commented Jan 9, 2025

@gaborcsardi This is good to go from where I stand. Not sure why I didn't remove the draft label before the holidays, but oh well!

@jennybc jennybc marked this pull request as ready for review January 9, 2025 06:25
@jennybc
Copy link
Member Author

jennybc commented Jan 9, 2025

Another variation on #744 (comment) is that if you always want cli to emit vscode://file or positron://file links when R is running in an integrated VS Code or Positron terminal, respectively, is that you can put something like this in your user settings, e.g.:

{
    "terminal.integrated.env.osx": {
        "R_CLI_HYPERLINKS": "true",
        "R_CLI_HYPERLINK_FILE_URL_FORMAT": "positron://file{path}:{line}:{column}"
    }
}

It appears this is what cli has always done with a leading `./`, so just keep doing that until there's reason not to.
@gaborcsardi gaborcsardi merged commit a3cef9f into main Jan 10, 2025
13 checks passed
@gaborcsardi gaborcsardi deleted the configurable-file-hyperlinks branch January 10, 2025 09:22
jennybc added a commit to posit-dev/positron that referenced this pull request Jan 14, 2025
Addresses #5409

*Needed to wait for r-lib/cli#744, which is now
merged*

`@:r-pkg-development`

### QA Notes

Pre-requisite: You need to install a very recent version of the cli
package. At the time I write this, this means a dev version of cli,
although I think we'll get a release out fairly soon. In the meantime, a
good way to install is:

```r
pak::pak("r-lib/cli")
```

Make sure the cli version is >= 3.6.3.9002:

``` r
packageVersion("cli")
#> [1] '3.6.3.9002'
```

There won't be any obvious error in the presence of an older cli
version, but the new functionality just won't activate.

Then you need to run tests on a package with one or more failing tests,
in order to be able to click on the filepath when test failure is
reported. This should take you directly to the relevant test location.

I have made a toy package that could be obtained via
[`usethis::create_from_github("jennybc/clilinks")`](https://github.com/jennybc/clilinks).
It has a couple of snapshot tests that will always fail 😄 because they
attempt to snapshot a random number. But really any package with a
failing test will do.

* Install dev cli: `pak::pak("r-lib/cli")`
* Identify a package with a failing test and open it in Positron,
perhaps via: `usethis::create_from_github("jennybc/clilinks")`
* Use our gesture for running package tests: Ctrl/Cmd + Shift + T or
select *R: Test R Package* from the command palette.
* Click on a file hyperlink for a failing test:
- Note this requires Ctrl/Cmd click! This is a VS Code convention, not
specific to us.
- Note that you might have to click twice. This is a bug (or 2 bugs?)
for which fixes are making their way through the system
(microsoft/vscode#230010). Again, not us.
- You might need to grant permission to open the file hyperlink. I think
I have long since checked some box always permitting this for local
files. This is a VS Code feature.
<img width="652" alt="file-hyperlink"
src="https://github.com/user-attachments/assets/3c1c7a11-e545-4ae8-8891-991d3e22c032"
/>

---

Note that this PR removes the feature flag introduced in #5231, since
now all hyperlinks work (if the cli version is recent enough). If you
configured `positron://settings/positron.r.taskHyperlinks` in the
interim, that setting can be removed and, indeed, no longer exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants