-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention keyring package in Wrapping APIs vignette? #346
Comments
What’s the advantage of doing that that you’re thinking of? |
Storing the secrets in the OS' credentials store is supposed to be safer than storing them in .Renviron. |
I too noticed Interested in this discussion as e.g. |
Hmmm, I guess since I wrote that httr vignette I'm no longer sure that the keyring is that much more secure. I think it's theoretically more secure, but in practice it's unlikely to make much difference because for an attacker to have access to your OTOH maybe people are using project specific |
Right, maybe it just feels more secure but your point about git seems important. More niche and less important:
|
Hmmmm, this all feels like it should maybe be a separate vignette that's env vars vs keychain, but then httr2 doesn't feel like quite the right place for it. Maybe it would be better as a keyring vignette? |
but how would httr2 users even think of reading keyring docs, could there be a pointer, even small? 🙂 |
Right, we'd point to it everywhere we mention env vars. |
I updated the keyring readme: https://keyring.r-lib.org/dev/. Do you think that's sufficient for selling it as an alternative to env vars or do I need to write more? |
Nice, thank you! I added comments in r-lib/keyring#139 😸 |
I think this requires more than just a change to the docs: for it to be a useful (and meaningfully more secure workflow), |
More precisely, should this workflow be added to that vignette: In an API package doc, recommend the user store their API key with keyring and retrieve it with
Sys.getenv(API_KEY=keyring::key_get("API-NAME")
?The text was updated successfully, but these errors were encountered: