Should deprecate and friends take a `call` argument?

[hadley]

Seems like it would be useful to display that in the warning.

[lionel-]

oh yes, that'd be nice (even though we are not in control of display for warnings so it'll look slightly different than calls generated by rlang).

[DavisVaughan]

See tidyverse/dplyr#7709

This would be particularly useful for lifecycle warnings in pipe chains. It is currently hard to figure out which step of the pipe chain the warning comes from

library(tidyverse)

df <- data.frame(
  x = 1:3,
  y = c("a", "d,e,f", "g,h"),
  z = c("1", "2,3,4", "5,6")
)

old_name <- "y"
new_name <- "new_y"
df %>%
  rename("{new_name}" := old_name) %>%
  filter(!is.na(.data[[new_name]]))
#> Warning: Using an external vector in selections was deprecated in tidyselect 1.1.0.
#> ℹ Please use `all_of()` or `any_of()` instead.
#>   # Was:
#>   data %>% select(old_name)
#> 
#>   # Now:
#>   data %>% select(all_of(old_name))
#> 
#> See <https://tidyselect.r-lib.org/reference/faq-external-vector.html>.
#> This warning is displayed once every 8 hours.
#> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was
#> generated.
#>
#>   x new_y     z
#> 1 1     a     1
#> 2 2 d,e,f 2,3,4
#> 3 3   g,h   5,6

Here it's from the rename() but that is non-obvious in a big chain of steps.

This would be better if we could swing it

#> Warning:
#> In `rename()`:
#> Using an external vector in selections was deprecated in tidyselect 1.1.0.
#> ℹ Please use `all_of()` or `any_of()` instead.
#>   # Was:
#>   data %>% select(old_name)
#> 
#>   # Now:
#>   data %>% select(all_of(old_name))

Not sure how all that works given that we use warning() rather than rlang::warn() though