Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crayon/cli output does not render correctly when comment="" #2196

Closed
gmbecker opened this issue Sep 19, 2022 · 2 comments
Closed

crayon/cli output does not render correctly when comment="" #2196

gmbecker opened this issue Sep 19, 2022 · 2 comments

Comments

@gmbecker
Copy link

gmbecker commented Sep 19, 2022 •
edited
Loading

I believe this is a still-alive case of #1843

When the comment chunk option is set to "", we (still) see the eroneous escaped ansi color codes in output.

To reproduce, set the comment option in vignettes/test/rendering.Rmd to "", and then build the articles for pkgdown itself. When you view the produced html page for that vignette, you will see:

Screen Shot 2022-09-19 at 3 40 55 PM

Which you do not see with the current value of comment="#>"
@gmbecker gmbecker mentioned this issue Sep 19, 2022
Closed
gmbecker added a commit to insightsengineering/rtables that referenced this issue Sep 19, 2022
@gmbecker
(hopefully temp) workaround for r-lib/pkgdown#2196. closes #396
81ecf68
@maelle
Copy link
Collaborator

maelle commented Nov 25, 2022

I've just realized this is a duplicate of #1965, sorry and thanks for reporting!

@maelle
Copy link
Collaborator

maelle commented Nov 25, 2022

Duplicate of #1965

@maelle maelle marked this as a duplicate of #1965 Nov 25, 2022
@maelle maelle closed this as completed Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmbecker @maelle