Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RealFavicon API now returns different set of favicons #2801

Open
willgearty opened this issue Oct 24, 2024 · 0 comments · May be fixed by #2804
Open

RealFavicon API now returns different set of favicons #2801

willgearty opened this issue Oct 24, 2024 · 0 comments · May be fixed by #2804

Comments

@willgearty
Copy link

willgearty commented Oct 24, 2024 •
edited
Loading

It looks like the RealFavicon API has changed (probably associated with this), because it no longer returns the same set of favicons. Of the hardcoded filenames in the BS5 template, only "apple-touch-icon.png" is still returned:

pkgdown/inst/BS5/templates/head.html

Lines 8 to 13 in 8d9cba1

<link rel="icon" type="image/png" sizes="16x16" href="{{#site}}{{root}}{{/site}}favicon-16x16.png">
<link rel="icon" type="image/png" sizes="32x32" href="{{#site}}{{root}}{{/site}}favicon-32x32.png">
<link rel="apple-touch-icon" type="image/png" sizes="180x180" href="{{#site}}{{root}}{{/site}}apple-touch-icon.png" />
<link rel="apple-touch-icon" type="image/png" sizes="120x120" href="{{#site}}{{root}}{{/site}}apple-touch-icon-120x120.png" />
<link rel="apple-touch-icon" type="image/png" sizes="76x76" href="{{#site}}{{root}}{{/site}}apple-touch-icon-76x76.png" />
<link rel="apple-touch-icon" type="image/png" sizes="60x60" href="{{#site}}{{root}}{{/site}}apple-touch-icon-60x60.png" />

This then causes the favicon to not render on some devices (e.g., Chrome/Edge on Windows). Here's the website I've recently built for my new R package as an example: https://williamgearty.com/deeptimedata. The list of favicons as built by build_favicons() can be seen here.
jayhesselberth added a commit that referenced this issue Oct 25, 2024
@jayhesselberth
Update favicon links in head
066c901 
Based on breaking changes from https://realfavicongenerator.net/

Fixes #2801
@jayhesselberth jayhesselberth linked a pull request Oct 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update favicon links in head r-lib/pkgdown
1 participant
@willgearty