version_tooltip works again in dev mode: auto
#2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ou couldn't call directly without init_site()
olivroy
commented
Jul 4, 2024
| @@ -122,7 +122,13 @@ data_template <- function(pkg = ".", depth = 0L) { | |||
|
|
|||
| # Development settings; tooltip needs to be generated at render time | |||
| out$development <- pkg$development | |||
| out$development$version_tooltip <- version_tooltip(pkg$development$mode) | |||
| if (identical(pkg$development$mode, "devel")) { | |||
There was a problem hiding this comment.
Suggested change
| if (identical(pkg$development$mode, "devel")) { | |
| if (identical(pkg$development$mode, "devel") && identical(pkg$meta$development$mode, "auto")) { |
|
@olivroy do you want to polish off this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2692. I see that some PR was made a while back (#1786), so I am only supporting this if dev mode is auto
It works (with my test example)