Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused dependencies and fix cargo deny #215

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Jun 20, 2024

  1. Remove unused dependencies in different crates. Using cargo machete to detect unused dependencies.
  2. Run cargo update to update to the latest semver compatible version.
    This close the issue Vulnerability dependency #173
  3. Remove that issue from the ignore list in thedeny.toml file.
  4. cargo deny check advisories has revealed a new vulnerability in one of the dependencies. Opened an issue in the repository Vulnerability dependency #214 and included it in the ignore list in the deny.toml file.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.25%. Comparing base (36ac44d) to head (7ddfcdf).

@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   57.25%   57.25%           
=======================================
  Files          34       34           
  Lines        3701     3701           
  Branches     3701     3701           
=======================================
  Hits         2119     2119           
  Misses       1243     1243           
  Partials      339      339           

@AlexD10S AlexD10S requested a review from evilrobot-01 June 20, 2024 11:01
Copy link
Contributor

@evilrobot-01 evilrobot-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Great to see all the red lines in the cargo.lock file.

@AlexD10S AlexD10S merged commit 130e1b2 into main Jun 20, 2024
15 checks passed
@AlexD10S AlexD10S deleted the fix/dependencies branch June 20, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants