al3mart/query_state & pop_api_primitives #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al3mart
changed the title
al3mart
changed the title
evilrobot-01
added a commit
that referenced
this pull request
Mar 6, 2024
* demo_contract:query_runtime * pop-api-ext:query * read relay_block# & state * unused import * ci: add build workflow * chore: improve zombienet config * ci: grant write permission to actions * feat: initialize pop-api directory * feat: add codec indexes, and wrap NFT interface * feat: add example contract utilizing pop-api crate -- not working * feat: minting NFT from contract through runtime works * feat: generic state reads * chore: fmt * RuntimeStateKeys * clean keys * fmt * cumulus_parachain_system is accessible --------- Co-authored-by: Frank Bell <[email protected]> Co-authored-by: Peter White <[email protected]>
evilrobot-01
added a commit
that referenced
this pull request
Mar 6, 2024
* demo_contract:query_runtime * pop-api-ext:query * read relay_block# & state * unused import * ci: add build workflow * chore: improve zombienet config * ci: grant write permission to actions * feat: initialize pop-api directory * feat: add codec indexes, and wrap NFT interface * feat: add example contract utilizing pop-api crate -- not working * feat: minting NFT from contract through runtime works * feat: generic state reads * chore: fmt * RuntimeStateKeys * clean keys * fmt * cumulus_parachain_system is accessible --------- Co-authored-by: Frank Bell <[email protected]> Co-authored-by: Peter White <[email protected]>
peterwht
added a commit
that referenced
this pull request
Mar 6, 2024
* feat: PoC of chain-extension reimplementing call_runtime * feat: use proper origin for pop api chain extension, start weight calculations * feat: start adding unit test for pop api chain extension * chore: update cargo.lock * feat: unit test works for pop api chain extension * chore: cargo fmt * feat: pop api crate (#16) * ci: add build workflow * chore: improve zombienet config * ci: grant write permission to actions * feat: initialize pop-api directory * feat: add codec indexes, and wrap NFT interface * feat: add example contract utilizing pop-api crate -- not working * feat: minting NFT from contract through runtime works * feat pop api crate refactoring and test (#15) * refactor: simplify api usage from contract * test: add NFT mint unit test to pop api extension --------- Co-authored-by: Frank Bell <[email protected]> --------- Co-authored-by: Frank Bell <[email protected]> * feat: add secure weight charging for pop-api extension * chore: update zombienet config * feat: query_state & pop_api_primitives (#14) * demo_contract:query_runtime * pop-api-ext:query * read relay_block# & state * unused import * ci: add build workflow * chore: improve zombienet config * ci: grant write permission to actions * feat: initialize pop-api directory * feat: add codec indexes, and wrap NFT interface * feat: add example contract utilizing pop-api crate -- not working * feat: minting NFT from contract through runtime works * feat: generic state reads * chore: fmt * RuntimeStateKeys * clean keys * fmt * cumulus_parachain_system is accessible --------- Co-authored-by: Frank Bell <[email protected]> Co-authored-by: Peter White <[email protected]> * fix: failing contract builds * refactor: general refactoring, versioned function selector and code cleanup * feat(pop-api): errors * refactor: improve error handling * chore: tidy up manifest * clean & rename tests * refactor: clean up and simplify * test: ignore tests which expect built contracts * style: formatting --------- Co-authored-by: Frank Bell <[email protected]> Co-authored-by: Alejandro Martinez Andres <[email protected]> Co-authored-by: Frank Bell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request implements a first version of pop-api: block number querying and prepares the ground for general runtime state reads.
It implements the
enumSafeKeys, which if not changing the approach, should be moved out of this repository into pop-api. So that both, contracts and runtime can depend on and have a shared understanding.At the same time restructures the extensions module in the following way:
EDIT:
Still no tests, but there is a contract implementing reading state from the runtime.
Refactors
SafeKeysintoRuntimeStateKeysIntroduces
pop-api-primitivesMerges branch
feat/pop-api-crate-> Contracts can now use nfts :D 🎉