feat(pallet-nfts): optimization #2034
clippy
245 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 245 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.83.0 (90b35a623 2024-11-26)
- cargo 1.83.0 (5ffbef321 2024-10-29)
- clippy 0.1.83 (90b35a6 2024-11-26)
Annotations
Check warning on line 44 in node/src/cli.rs
github-actions / clippy
large size difference between variants
warning: large size difference between variants
--> node/src/cli.rs:5:1
|
5 | / pub enum Subcommand {
6 | | /// Build a chain specification.
7 | | BuildSpec(sc_cli::BuildSpecCmd),
... |
19 | | ImportBlocks(sc_cli::ImportBlocksCmd),
| | ------------------------------------- the second-largest variant contains at least 240 bytes
... |
39 | | Benchmark(frame_benchmarking_cli::BenchmarkCmd),
| | ----------------------------------------------- the largest variant contains at least 544 bytes
... |
43 | | Key(sc_cli::KeySubcommand),
44 | | }
| |_^ the entire enum is at least 544 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
39 | Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Check warning on line 34 in node/src/rpc.rs
github-actions / clippy
field `backend` is never read
warning: field `backend` is never read
--> node/src/rpc.rs:34:6
|
26 | pub struct FullDeps<C, P, B> {
| -------- field in this struct
...
34 | pub backend: Arc<B>,
| ^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 128 in runtime/devnet/src/config/xcm.rs
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/xcm.rs:128:1
|
128 | pub struct XcmConfig;
| ^^^^^^^^^^^^^^^^^^^^
Check warning on line 126 in runtime/devnet/src/config/xcm.rs
github-actions / clippy
missing documentation for a type alias
warning: missing documentation for a type alias
--> runtime/devnet/src/config/xcm.rs:126:1
|
126 | pub type TrustedReserves = (NativeAsset, NativeAssetFrom<AssetHub>);
| ^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 101 in runtime/devnet/src/config/xcm.rs
github-actions / clippy
missing documentation for a type alias
warning: missing documentation for a type alias
--> runtime/devnet/src/config/xcm.rs:101:1
|
101 | pub type Barrier = TrailingSetTopicAsId<(
| ^^^^^^^^^^^^^^^^
Check warning on line 94 in runtime/devnet/src/config/xcm.rs
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/xcm.rs:94:1
|
94 | pub struct ParentOrParentsExecutivePlurality;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/xcm.rs:87:1
|
87 | / parameter_types! {
88 | | // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
89 | | pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
90 | | pub const MaxInstructions: u32 = 100;
91 | | pub const MaxAssetsIntoHolding: u32 = 64;
92 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/xcm.rs:87:1
|
87 | / parameter_types! {
88 | | // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
89 | | pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
90 | | pub const MaxInstructions: u32 = 100;
91 | | pub const MaxAssetsIntoHolding: u32 = 64;
92 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/xcm.rs:87:1
|
87 | / parameter_types! {
88 | | // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
89 | | pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
90 | | pub const MaxInstructions: u32 = 100;
91 | | pub const MaxAssetsIntoHolding: u32 = 64;
92 | | }
| |_^
|
= note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/xcm.rs:28:1
|
28 | / parameter_types! {
29 | | pub const RelayLocation: Location = Location::parent();
30 | | pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | | // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
... |
36 | | pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/xcm.rs:28:1
|
28 | / parameter_types! {
29 | | pub const RelayLocation: Location = Location::parent();
30 | | pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | | // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
... |
36 | | pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/xcm.rs:28:1
|
28 | / parameter_types! {
29 | | pub const RelayLocation: Location = Location::parent();
30 | | pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | | // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
... |
36 | | pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/xcm.rs:28:1
|
28 | / parameter_types! {
29 | | pub const RelayLocation: Location = Location::parent();
30 | | pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | | // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
... |
36 | | pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/xcm.rs:28:1
|
28 | / parameter_types! {
29 | | pub const RelayLocation: Location = Location::parent();
30 | | pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | | // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
... |
36 | | pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
| |_^
|
= note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 103 in runtime/devnet/src/config/assets.rs
github-actions / clippy
missing documentation for a type alias
warning: missing documentation for a type alias
--> runtime/devnet/src/config/assets.rs:103:1
|
103 | pub type TrustBackedAssetsCall = pallet_assets::Call<Runtime, TrustBackedAssetsInstance>;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/assets.rs:76:1
|
76 | / parameter_types! {
77 | | pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
78 | | pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
79 | | pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
80 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/assets.rs:76:1
|
76 | / parameter_types! {
77 | | pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
78 | | pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
79 | | pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
80 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/assets.rs:76:1
|
76 | / parameter_types! {
77 | | pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
78 | | pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
79 | | pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
80 | | }
| |_^
|
= note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/assets.rs:30:1
|
30 | / parameter_types! {
31 | | pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | | pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | | /// Key = 116 bytes (4+16+32+16+32+16), Value = 17 bytes (1+8+8)
... |
39 | | pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
40 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/assets.rs:30:1
|
30 | / parameter_types! {
31 | | pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | | pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | | /// Key = 116 bytes (4+16+32+16+32+16), Value = 17 bytes (1+8+8)
... |
39 | | pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
40 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/assets.rs:30:1
|
30 | / parameter_types! {
31 | | pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | | pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | | /// Key = 116 bytes (4+16+32+16+32+16), Value = 17 bytes (1+8+8)
... |
39 | | pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
40 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/assets.rs:30:1
|
30 | / parameter_types! {
31 | | pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | | pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | | /// Key = 116 bytes (4+16+32+16+32+16), Value = 17 bytes (1+8+8)
... |
39 | | pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
40 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/assets.rs:30:1
|
30 | / parameter_types! {
31 | | pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | | pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | | /// Key = 116 bytes (4+16+32+16+32+16), Value = 17 bytes (1+8+8)
... |
39 | | pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
40 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/assets.rs:30:1
|
30 | / parameter_types! {
31 | | pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | | pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | | /// Key = 116 bytes (4+16+32+16+32+16), Value = 17 bytes (1+8+8)
... |
39 | | pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
40 | | }
| |_^
|
= note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> runtime/devnet/src/config/assets.rs:30:1
|
30 | / parameter_types! {
31 | | pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | | pub const NftsCollectionDeposit: Balance = 10 * UNIT;
33 | | /// Key = 116 bytes (4+16+32+16+32+16), Value = 17 bytes (1+8+8)
... |
39 | | pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
40 | | }
| |_^
|
= note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)