Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts #4

Open
maxs15 opened this issue May 29, 2018 · 2 comments
Open

Fonts #4

maxs15 opened this issue May 29, 2018 · 2 comments

Comments

@maxs15
Copy link

maxs15 commented May 29, 2018

Hey @raarts, awesome work on this lib !

I'm wondering, why are you including all the fonts (Feather, EvilIcons..) ?
The issue is that they will be included in the bundle even if we don't use them and the bundle will be very heavy..
Why not have a separate repo like expo/vector-icons ?

Thanks

@raarts
Copy link
Owner

raarts commented May 30, 2018

Hi, initially I did not care for optimization, just get it working first. A bit later, this repo was integrated into Expo, and I kind of decided this repo wasn't really needed any more. Also I figured webpack would be able to do some tree-shaking on this, but I haven't look into it yet.

@jaulz
Copy link
Contributor

jaulz commented Jul 19, 2018

@raarts if I drop expo-web completely I get issues like these:
Can't resolve './effects/BlurView' in '`...\node_modules\expo\src'

What would be your recommendation how to implement react-native-web and expo together? Also I saw that some features were already dropped again from the repo:
https://github.com/expo/expo-sdk/commit/fe888e43146b064cb1df3676fe8a47f6b452eee3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants