Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a synchronous write loop for connections. #1389

Closed
wants to merge 1 commit into from

Conversation

michac
Copy link
Contributor

@michac michac commented Sep 21, 2023

Proposed Changes

Add an option to make the WriteLoop in the SocketFrameHandler run in its own dedicated thread. In this version (6.x) most operations are blocking (CreateModel, QueueDeclare etc...) using BlockingCell. This can create a situation where all the threadpool threads are blocked waiting for a response to a message that can't get sent because there are no threads left for the WriteLoop. See #1354

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

If this is a relatively large or complex change, kick off the discussion by
explaining why you chose the solution you did and what alternatives you
considered, etc.

@paulomorgado
Copy link
Contributor

Why should the RabbitMQ client account for application thread management?

The tread pool can be configured to accommodate the needs of the application.

@lukebakken
Copy link
Contributor

Please see #1392

@lukebakken lukebakken closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants