Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test logging in locator v2 #234

Open
ablease opened this issue Sep 25, 2023 · 2 comments · Fixed by #236
Open

Test logging in locator v2 #234

ablease opened this issue Sep 25, 2023 · 2 comments · Fixed by #236
Labels
enhancement New feature or request v2.x Applicable to v2.x issues

Comments

@ablease
Copy link

ablease commented Sep 25, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

See this TODO:

rabbitmq-stream-go-client/pkg/stream/locator_test.go

Line 74 in a6cced8

// TODO: add a test for logs

Describe the solution you'd like
@ablease ablease added enhancement New feature or request v2.x Applicable to v2.x issues labels Sep 25, 2023
@Zerpet Zerpet linked a pull request Sep 27, 2023 that will close this issue
Add logging unit tests to locator #236
Merged
@Zerpet
Copy link
Contributor

Zerpet commented Sep 28, 2023

Somehow GitHub did not close this issue after merging the PR.

@Zerpet Zerpet closed this as completed Sep 28, 2023
@ablease
Copy link
Author

ablease commented Sep 29, 2023

Going to reopen this, to add tests for logging during the shutdown.

@ablease ablease reopened this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request v2.x Applicable to v2.x issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add logging unit tests to locator rabbitmq/rabbitmq-stream-go-client
2 participants
@Zerpet @ablease