Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [ACI-249] extract and unify #142

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

wowkalucky
Copy link
Collaborator

No description provided.

@wowkalucky wowkalucky self-assigned this Apr 15, 2024
@wowkalucky
Copy link
Collaborator Author

@andrii-hantkovskyi
current state:

================================================================= short test summary info ==================================================================
FAILED credentials/apps/badges/tests/test_handlers.py::SignalHandlersTestCase::test_prevent_deletion_if_active - AssertionError: ValidationError not raised
FAILED credentials/apps/badges/tests/test_models.py::BadgeTemplateUserProgressTestCase::test_user_progress_no_fulfillments - TypeError: for_user() got an...
FAILED credentials/apps/badges/tests/test_models.py::BadgeTemplateUserProgressTestCase::test_user_progress_no_requirements - TypeError: for_user() got an...
FAILED credentials/apps/badges/tests/test_models.py::BadgeTemplateUserProgressTestCase::test_user_progress_success - TypeError: for_user() got an unexpec...
FAILED credentials/apps/badges/tests/test_models.py::BadgeTemplateUserCompletionTestCase::test_is_completed_failure - TypeError: for_user() got an unexpe...
FAILED credentials/apps/badges/tests/test_models.py::BadgeTemplateUserCompletionTestCase::test_is_completed_no_requirements - TypeError: for_user() got a...
FAILED credentials/apps/badges/tests/test_models.py::BadgeTemplateUserCompletionTestCase::test_is_completed_success - TypeError: for_user() got an unexpe...
FAILED credentials/apps/badges/tests/test_services.py::TestProcessPenalties::test_process_penalties_all_datarules_success - TypeError: notify_requirement...
FAILED credentials/apps/badges/tests/test_signals.py::BadgeSignalReceiverTestCase::test_signal_emission_and_receiver_execution - AssertionError: False is...
========================================================= 9 failed, 27 passed, 7 warnings in 5.22s =========================================================

@wowkalucky
Copy link
Collaborator Author

wowkalucky commented Apr 15, 2024

Update:

================================================================= short test summary info ==================================================================
FAILED credentials/apps/badges/tests/test_handlers.py::SignalHandlersTestCase::test_prevent_deletion_if_active - AssertionError: ValidationError not raised
FAILED credentials/apps/badges/tests/test_services.py::TestProcessPenalties::test_process_penalties_all_datarules_success - TypeError: notify_requirement...
FAILED credentials/apps/badges/tests/test_signals.py::BadgeSignalReceiverTestCase::test_signal_emission_and_receiver_execution - AssertionError: False is...
========================================================= 3 failed, 33 passed, 7 warnings in 5.26s =========================================================

@wowkalucky
Copy link
Collaborator Author

@andrii-hantkovskyi merging it. Need your help tomorrow on it.

@wowkalucky wowkalucky marked this pull request as ready for review April 16, 2024 09:28
@wowkalucky wowkalucky merged commit 310d341 into aci.main Apr 16, 2024
2 checks passed
@wowkalucky wowkalucky deleted the bergman/pre-release-checks branch April 16, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant