fix: make production plugins settings managed from environment #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wowkalucky
force-pushed
the
bergman/refactor-plugins-settings-injection
branch
from
c66a1b1
to
75e3673
Compare
|
Peremoga. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point in time, plugin support was added to the Credentials project.
Plugins' settings are injected at the initialization step.
But the issue is production settings are injected at the very end (when environment overrides are already applied), so it makes it impossible to manage any of the settings that are defined in plugins.
The PR addresses the issue by moving plugins' settings injection right before the environment configuration
yamlprocessing.