Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadFromLinks method signature mismatch with loadSingle #7

Open
martypdx opened this issue Jul 9, 2014 · 1 comment
Open

loadFromLinks method signature mismatch with loadSingle #7

martypdx opened this issue Jul 9, 2014 · 1 comment

Comments

@martypdx
Copy link
Contributor

martypdx commented Jul 9, 2014

return function loadFromLinks( baseUrl, cache ) {
...
    links.forEach( function( link ) {
    var name = getNameFromLink( link );
    // one, two, three
    loadSingle( link.getAttribute( 'href' ), baseUrl, cache ).then(...
// one, two, three, four
function loadSingle( path, parentUrl, baseUrl, cache ) {
    var promise, url;
    ...
@MartinKolarik
Copy link
Member

Also, I noticed now that I didn't add the fourth parameter here:

// line 379
loadImport: function( name, path, parentUrl, callback ) {
    loadSingle( path, parentUrl, baseUrl ).then( callback, reject );
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants