Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize search input with query #302

Open
silvester-pari opened this issue Apr 13, 2023 · 3 comments · May be fixed by #388
Open

Synchronize search input with query #302

silvester-pari opened this issue Apr 13, 2023 · 3 comments · May be fixed by #388
Labels
Milestone

Comments

@silvester-pari
Copy link

Currently, some parts of the UI state are synchronized with the url via query parameters (like currently open panels etc.). Similarly, it would be great if the criteria the user inputs when performing a search could be synchronized with the query.

This way, by sharing the current url with another user, that second user would have the search criteria pre-filled and would see the same results as the first user.

This could apply to the /search page as well as to the filter boxes while browsing.

@m-mohr
Copy link
Collaborator

m-mohr commented Apr 13, 2023

Definitively an option and possible, the framework for it is already there.

In Search, this could also reflect whether it was submitted and auto-submit on reload.

@silvester-pari
Copy link
Author

In Search, this could also reflect whether it was submitted and auto-submit on reload.

If you ask me, it could auto-submit by default, because the reason a user might want to share a search input configuration is to show another user the results first and foremost (and the input params as a byproduct).

What would be the reason/use case for loading the search criteria without triggering the submit?

The query could actually be only set once the user triggers the search, this way it would make sense also in the other direction.

But I do not have a strong opinion about this, in the end I'm up for whatever is easier to implement I guess 😄

@m-mohr
Copy link
Collaborator

m-mohr commented Apr 13, 2023

If I select something in the form without submitting and then reload the page (for whatever reason), it's weird that it would auto-submit. But let's see in implementation what makes sense, it's minor thing anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants