From accff5c4c9c2b2f7b28977d2e59802b405d70dc0 Mon Sep 17 00:00:00 2001 From: lakshmimsft Date: Wed, 22 Jan 2025 10:02:08 -0800 Subject: [PATCH] remove check for err to get more logs Signed-off-by: lakshmimsft --- .github/workflows/functional-test-cloud.yaml | 9 ++------- .github/workflows/functional-test-noncloud.yaml | 1 + deploy/Chart/templates/ucp/configmaps.yaml | 2 +- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/.github/workflows/functional-test-cloud.yaml b/.github/workflows/functional-test-cloud.yaml index 2613e5c616..e8b88c9ea9 100644 --- a/.github/workflows/functional-test-cloud.yaml +++ b/.github/workflows/functional-test-cloud.yaml @@ -678,12 +678,6 @@ jobs: for i in {1..6}; do kubectl logs "$POD_NAME" -n radius-system | tee registermanifest_logs.txt > /dev/null - # Exit on error - if grep -qi "error" registermanifest_logs.txt; then - echo "Error found in ucp logs." - exit 1 - fi - # Check for success if grep -q "Successfully registered manifests" registermanifest_logs.txt; then echo "Successfully registered manifests - message found." @@ -721,6 +715,7 @@ jobs: rad credential register aws irsa \ --iam-role ${{ secrets.FUNC_TEST_RAD_IRSA_ROLE }} + continue-on-error: true - uses: marocchino/sticky-pull-request-comment@v2 if: failure() && env.PR_NUMBER != '' @@ -946,4 +941,4 @@ jobs: title: `Scheduled functional test failed - Run ID: ${context.runId}`, labels: ['bug', 'test-failure'], body: `## Bug information \n\nThis issue is automatically generated if the scheduled functional test fails. The Radius functional test operates on a schedule of every 4 hours during weekdays and every 12 hours over the weekend. It's important to understand that the test may fail due to workflow infrastructure issues, like network problems, rather than the flakiness of the test itself. For the further investigation, please visit [here](${process.env.ACTION_LINK}).` - }) + }) \ No newline at end of file diff --git a/.github/workflows/functional-test-noncloud.yaml b/.github/workflows/functional-test-noncloud.yaml index 0ff7586d9b..4fb0790d40 100644 --- a/.github/workflows/functional-test-noncloud.yaml +++ b/.github/workflows/functional-test-noncloud.yaml @@ -341,6 +341,7 @@ jobs: # The functional test is designed to use default namespace. So you must create the environment for default namespace. rad env create kind-radius --namespace default rad env switch kind-radius + continue-on-error: true env: USE_CERT_FILE: "true" TEMP_CERT_DIR: ${{ steps.create-local-registry.outputs.temp-cert-dir }} diff --git a/deploy/Chart/templates/ucp/configmaps.yaml b/deploy/Chart/templates/ucp/configmaps.yaml index 4b29bfdb47..16d12a8d80 100644 --- a/deploy/Chart/templates/ucp/configmaps.yaml +++ b/deploy/Chart/templates/ucp/configmaps.yaml @@ -50,7 +50,7 @@ data: - id: "/planes/aws/aws" properties: kind: "AWS" - manifestDirectory: "/manifest/built-in-providers" + manifestDirectory: "simulatefailure" identity: authMethod: UCPCredential