[WIP/DO NOT REVIEW] UDT - Remove Legacy Routing #8205

lakshmimsft · 2025-01-08T16:28:22Z

Description

Remove Legacy Routing. Update tests as necessary
Add global location, address to manifests

Type of change

This pull request adds or changes features of Radius and has an approved issue (User-Defined Resource Types #6688 ).

Part of: #6688

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
A design document PR is created in the design-notes repository, if new APIs are being introduced.
If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

radius-functional-tests · 2025-01-08T17:55:53Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`94382b0`
Unique ID	funcd3eb7cf3c1
Image tag	pr-funcd3eb7cf3c1

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcd3eb7cf3c1
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcd3eb7cf3c1
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcd3eb7cf3c1
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcd3eb7cf3c1
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcd3eb7cf3c1
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

codecov · 2025-01-08T18:42:34Z

Codecov Report

Attention: Patch coverage is 41.02564% with 23 lines in your changes missing coverage. Please review.

Project coverage is 59.72%. Comparing base (845f88d) to head (11b4f4f).

Files with missing lines	Patch %	Lines
pkg/cli/manifest/registermanifest.go	40.00%	19 Missing and 2 partials ⚠️
pkg/ucp/frontend/controller/resourcegroups/util.go	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8205      +/-   ##
==========================================
- Coverage   59.73%   59.72%   -0.01%     
==========================================
  Files         590      590              
  Lines       39487    39483       -4     
==========================================
- Hits        23588    23582       -6     
- Misses      14152    14153       +1     
- Partials     1747     1748       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

radius-functional-tests · 2025-01-10T08:38:14Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`c8c1be3`
Unique ID	func7bdea55e54
Image tag	pr-func7bdea55e54

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7bdea55e54
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7bdea55e54
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func7bdea55e54
controller test image location: ghcr.io/radius-project/dev/controller:pr-func7bdea55e54
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7bdea55e54
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
❌ Failed to install Radius for corerp-cloud functional test. Please check the logs for more details
❌ corerp-cloud functional test failed. Please check the logs for more details
❌ ucp-cloud functional test cancelled. Please check the logs for more details

Signed-off-by: lakshmimsft <[email protected]>

radius-functional-tests · 2025-01-10T22:47:18Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`cf8042e`
Unique ID	func447998d1ea
Image tag	pr-func447998d1ea

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func447998d1ea
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func447998d1ea
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func447998d1ea
controller test image location: ghcr.io/radius-project/dev/controller:pr-func447998d1ea
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func447998d1ea
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details

radius-functional-tests · 2025-01-10T23:58:32Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`e7ff53c`
Unique ID	func97987471d5
Image tag	pr-func97987471d5

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func97987471d5
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func97987471d5
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func97987471d5
controller test image location: ghcr.io/radius-project/dev/controller:pr-func97987471d5
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func97987471d5
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Signed-off-by: lakshmimsft <[email protected]>

radius-functional-tests · 2025-01-11T02:26:30Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	lakshmimsft/radius-mainfork
Commit ref	`11b4f4f`
Unique ID	funcdb51c7693a
Image tag	pr-funcdb51c7693a

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcdb51c7693a
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcdb51c7693a
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcdb51c7693a
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcdb51c7693a
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcdb51c7693a
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 3c22547 to 94382b0 Compare January 8, 2025 17:47

lakshmimsft temporarily deployed to publish-bicep January 8, 2025 17:48 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 8, 2025 17:48 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 94382b0 to 138974f Compare January 9, 2025 00:09

lakshmimsft temporarily deployed to publish-bicep January 9, 2025 00:09 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to publish-bicep January 10, 2025 08:36 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 10, 2025 08:37 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from c8c1be3 to 07f1803 Compare January 10, 2025 22:43

lakshmimsft temporarily deployed to publish-bicep January 10, 2025 22:43 — with GitHub Actions Inactive

remove legacy routing

e004485

Signed-off-by: lakshmimsft <[email protected]>

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from 07f1803 to cf8042e Compare January 10, 2025 22:45

lakshmimsft temporarily deployed to publish-bicep January 10, 2025 22:46 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 10, 2025 22:46 — with GitHub Actions Inactive

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from cf8042e to e7ff53c Compare January 10, 2025 23:39

lakshmimsft temporarily deployed to publish-bicep January 10, 2025 23:39 — with GitHub Actions Inactive

lakshmimsft temporarily deployed to functional-tests January 10, 2025 23:57 — with GitHub Actions Inactive

enable register manifest

11b4f4f

Signed-off-by: lakshmimsft <[email protected]>

lakshmimsft force-pushed the lakshmimsft/removelegacyrouting branch from e7ff53c to 11b4f4f Compare January 11, 2025 02:24

lakshmimsft deployed to publish-bicep January 11, 2025 02:24 — with GitHub Actions Active

lakshmimsft deployed to functional-tests January 11, 2025 02:25 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP/DO NOT REVIEW] UDT - Remove Legacy Routing #8205

[WIP/DO NOT REVIEW] UDT - Remove Legacy Routing #8205

lakshmimsft commented Jan 8, 2025

radius-functional-tests bot commented Jan 8, 2025 •

edited

Loading

codecov bot commented Jan 8, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 11, 2025 •

edited

Loading

[WIP/DO NOT REVIEW] UDT - Remove Legacy Routing #8205

Are you sure you want to change the base?

[WIP/DO NOT REVIEW] UDT - Remove Legacy Routing #8205

Conversation

lakshmimsft commented Jan 8, 2025

Description

Type of change

Contributor checklist

radius-functional-tests bot commented Jan 8, 2025 • edited Loading

Radius functional test overview

Test Status

codecov bot commented Jan 8, 2025 • edited Loading

Codecov Report

radius-functional-tests bot commented Jan 10, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 10, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 10, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 11, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 8, 2025 •

edited

Loading

codecov bot commented Jan 8, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2025 •

edited

Loading

radius-functional-tests bot commented Jan 11, 2025 •

edited

Loading