Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete AWS Resources step sometimes fails if job is cancelled #1017

Closed
willdavsmith opened this issue Mar 18, 2024 · 2 comments
Closed

Delete AWS Resources step sometimes fails if job is cancelled #1017

willdavsmith opened this issue Mar 18, 2024 · 2 comments
Assignees
Labels
important This item is a high priority Issue we intend to address as soon as possible triaged This item has been triaged by project maintainers and is in the backlog

Comments

@willdavsmith
Copy link
Contributor

willdavsmith commented Mar 18, 2024

Sometimes, if the Test Samples workflow runs and is cancelled, something will cause the "Delete AWS Resources" step to get stuck in an infinite loop and cancel:

image

We could try adding the cancelled() condition here or making resource cleanups part of a different job.

AB#11549

@sylvainsf sylvainsf added triaged This item has been triaged by project maintainers and is in the backlog important This item is a high priority Issue we intend to address as soon as possible labels Mar 21, 2024
@ytimocin ytimocin self-assigned this Apr 26, 2024
@ytimocin
Copy link
Contributor

I updated this step to only run if the Deploy App step is successful and if Cancel Workflow is not called.

@ytimocin
Copy link
Contributor

ytimocin commented May 6, 2024

Continuing the discussion here: #1009.

@ytimocin ytimocin closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important This item is a high priority Issue we intend to address as soon as possible triaged This item has been triaged by project maintainers and is in the backlog
Projects
None yet
Development

No branches or pull requests

3 participants